Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Tamseel Shams'" <m.shams@samsung.com>, <kgene@kernel.org>,
        <krzk@kernel.org>, <gregkh@linuxfoundation.org>, <jslaby@suse.com>
Cc:     <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <20200810030021.45348-1-m.shams@samsung.com>
Subject: RE: [RFT PATCH v5] serial: samsung: Removes the IRQ not found
 warning
Date:   Mon, 10 Aug 2020 21:56:52 +0530
Message-ID: <003c01d66f33$1065a380$3130ea80$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQLjq31EwYjle3qnolStvtfndV72lwF+iMNMpwsaERA=
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <CGME20200810032514epcas5p1140fe0e44f3727953480ff0531c76b0c@epcas5p1.samsung.com>
        <20200810030021.45348-1-m.shams@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Tamseel,

> -----Original Message-----
> From: Tamseel Shams <m.shams=40samsung.com>
> Sent: 10 August 2020 08:30
> To: kgene=40kernel.org; krzk=40kernel.org; gregkh=40linuxfoundation.org;
> jslaby=40suse.com
> Cc: linux-arm-kernel=40lists.infradead.org; linux-samsung-soc=40vger.kern=
el.org;
> linux-serial=40vger.kernel.org; linux-kernel=40vger.kernel.org;
> alim.akhtar=40samsung.com; Tamseel Shams <m.shams=40samsung.com>
> Subject: =5BRFT PATCH v5=5D serial: samsung: Removes the IRQ not found wa=
rning
>=20
> In few older Samsung SoCs like s3c2410, s3c2412 and s3c2440, UART IP is h=
aving
> 2 interrupt lines.
> However, in other SoCs like s3c6400, s5pv210, exynos5433, and exynos4210
> UART is having only 1 interrupt line. Due to this, =22platform_get_irq(pl=
atdev, 1)=22
> call in the driver gives the following false-positive error:
> =22IRQ index 1 not found=22 on newer SoC's.
>=20
> This patch adds the condition to check for Tx interrupt only for the thos=
e SoC's
> which have 2 interrupt lines.
>=20
> Signed-off-by: Tamseel Shams <m.shams=40samsung.com>
> ---
Tested on exynos7 platform, don=E2=80=99t=20see=20=22=20IRQ=20index=201=20n=
ot=20found=22=20with=20this=20patch=20applied=0D=0AFill=20free=20to=20added=
=20=0D=0ATested-by:=20Alim=20Akhtar=20<alim.akhtar=40samsung.com>=0D=0ARevi=
ewed-by:=20Alim=20Akhtar=20<alim.akhtar=40samsung.com>=0D=0A=0D=0A>=20Commi=
t=20message=20is=20changed.=0D=0A>=20=0D=0A>=20Added=20RFT,=20for=20older=
=20platform.=0D=0A>=20=0D=0A>=20Addressed=20Krzysztof's=20review=20comments=
=20=5B1=5D=20=5B1=5D=20->=0D=0A>=20https://lkml.org/lkml/2020/7/21/150=0D=
=0A>=20=0D=0A>=20=20drivers/tty/serial/samsung_tty.c=20=7C=208=20+++++---=
=0D=0A>=20=201=20file=20changed,=205=20insertions(+),=203=20deletions(-)=0D=
=0A>=20=0D=0A>=20diff=20--git=20a/drivers/tty/serial/samsung_tty.c=20b/driv=
ers/tty/serial/samsung_tty.c=0D=0A>=20index=206ef614d8648c..b923683e6a25=20=
100644=0D=0A>=20---=20a/drivers/tty/serial/samsung_tty.c=0D=0A>=20+++=20b/d=
rivers/tty/serial/samsung_tty.c=0D=0A>=20=40=40=20-1911,9=20+1911,11=20=40=
=40=20static=20int=20s3c24xx_serial_init_port(struct=0D=0A>=20s3c24xx_uart_=
port=20*ourport,=0D=0A>=20=20=09=09ourport->tx_irq=20=3D=20ret=20+=201;=0D=
=0A>=20=20=09=7D=0D=0A>=20=0D=0A>=20-=09ret=20=3D=20platform_get_irq(platde=
v,=201);=0D=0A>=20-=09if=20(ret=20>=200)=0D=0A>=20-=09=09ourport->tx_irq=20=
=3D=20ret;=0D=0A>=20+=09if=20(=21s3c24xx_serial_has_interrupt_mask(port))=
=20=7B=0D=0A>=20+=09=09ret=20=3D=20platform_get_irq(platdev,=201);=0D=0A>=
=20+=09=09if=20(ret=20>=200)=0D=0A>=20+=09=09=09ourport->tx_irq=20=3D=20ret=
;=0D=0A>=20+=09=7D=0D=0A>=20=20=09/*=0D=0A>=20=20=09=20*=20DMA=20is=20curre=
ntly=20supported=20only=20on=20DT=20platforms,=20if=20DMA=20properties=0D=
=0A>=20=20=09=20*=20are=20specified.=0D=0A>=20--=0D=0A>=202.17.1=0D=0A=0D=
=0A=0D=0A