Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 10 Aug 2020 19:29:36 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Pavel Machek <pavel@denx.de>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        syzbot+1a54a94bd32716796edd@syzkaller.appspotmail.com,
        syzbot+9d2abfef257f3e2d4713@syzkaller.appspotmail.com,
        Hillf Danton <hdanton@sina.com>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 4.19 06/48] ALSA: seq: oss: Serialize ioctls
Message-ID: <20200810172936.GA82601@kroah.com>
References: <20200810151804.199494191@linuxfoundation.org>
 <20200810151804.528955642@linuxfoundation.org>
 <20200810163717.GA24408@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200810163717.GA24408@amd>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 10, 2020 at 06:37:17PM +0200, Pavel Machek wrote:
> Hi!
> 
> > commit 80982c7e834e5d4e325b6ce33757012ecafdf0bb upstream.
> > 
> > Some ioctls via OSS sequencer API may race and lead to UAF when the
> > port create and delete are performed concurrently, as spotted by a
> > couple of syzkaller cases.  This patch is an attempt to address it by
> > serializing the ioctls with the existing register_mutex.
> > 
> > Basically OSS sequencer API is an obsoleted interface and was designed
> > without much consideration of the concurrency.  There are very few
> > applications with it, and the concurrent performance isn't asked,
> > hence this "big hammer" approach should be good enough.
> 
> That really is a "big hammer". And I believe it is too big.

Please discuss code architecture decisions on the mailing list for the
subsystem/patch.  Doing it in random stable backports does not help out
as all of the developers involved are not copied here.

thanks,

greg k-h