Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp4536903pxa; Mon, 10 Aug 2020 11:28:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzdqirKPmbYkHxRNuTgrIKMu+gHy4+pcjw9cWwf6CIlTLCbbXSmKPq8DlJo7n7QIoRM2Y2m X-Received: by 2002:a17:906:f290:: with SMTP id gu16mr22215260ejb.502.1597084091112; Mon, 10 Aug 2020 11:28:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597084091; cv=none; d=google.com; s=arc-20160816; b=yE5ODA1SKJD4VpqG5c8C2mLBQ81nBUQ1xJX8Z2lYreGZPtBAPPk6GvZOrD+8WoQF87 /HEFgquwPPTQO9EvtW2rxPfuaZ1U/RNFIBYVQVR1X3p3yexm11evuPPpivOxQNW01r4Q Ie7JS/rvdNNUPWMEWgu8Iw1cIJr5cxRClX14QPtVxBjhJvHlY8dkSliaRH5e57bgC8Te 3RjEkM8jkBIdlTbiig53Aveg1grghKMfskBeiPpnmRAsSPRTBc4+8Dfak+GMTCTgMcQl 9K4C8CePF3/YCxaAskzdImaKCfHuzV5sIOI5nuxMJRSd1rbNcIlU0ZAO2sk8n7kSIy1V GT5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=cX4Msxnn5zC5yv1Zl/6rqMQrmt/WnxCW5dt1cBI9oxs=; b=gpH/PmAXkey6wK3IPbUQCNuvquixR8VjtcGMeEYrcv/2rG/0jAqRGKdEJCOoZHm/jG gSJ8qrnV6WCkQMXINU3fP1NXzhGa65TXwqOlWNLsOiEAmtE60NJ63JY9lFtArFZQd56O raKI+clabdj5p0T/4Z62uBRIPCAQBg8lOg/ylzETHy3FSKBb4OWJoQK4S1+7FeOrRPP1 isBNMxwphReBNk13TiKejSQ+eDY0Nj6gRm4V0RZusRPP3iIQ2+VNUmkvmiKVLys4Id/U THqoqPjBafYgGljoFZXCxuIduanF/B0MiazBwzxQjNctI5JNfgf8CsMcVCQKR5ZQkinw 9U2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r6si11489547edh.529.2020.08.10.11.27.46; Mon, 10 Aug 2020 11:28:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728095AbgHJS1R (ORCPT + 99 others); Mon, 10 Aug 2020 14:27:17 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:54584 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727982AbgHJS1Q (ORCPT ); Mon, 10 Aug 2020 14:27:16 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 4F7CB20023; Mon, 10 Aug 2020 20:27:13 +0200 (CEST) Date: Mon, 10 Aug 2020 20:27:12 +0200 From: Sam Ravnborg To: allen Cc: Jau-Chih Tseng , Hermes Wu , Kenneth Hung , Pi-Hsun Shih , David Airlie , Daniel Vetter , Rob Herring , "open list:DRM DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v1 1/2] ite-it6505 change trigger conditions Message-ID: <20200810182712.GA408647@ravnborg.org> References: <1597053278-25421-1-git-send-email-allen.chen@ite.com.tw> <1597053278-25421-2-git-send-email-allen.chen@ite.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1597053278-25421-2-git-send-email-allen.chen@ite.com.tw> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=d2tX9T8KrmGLFF5Hj1IA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Allen. On Mon, Aug 10, 2020 at 05:53:17PM +0800, allen wrote: > it6505 changes trigger conditions. > --- > Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > index 2c50016..bf0e889 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > @@ -73,7 +73,7 @@ examples: > > dp-bridge@5c { > compatible = "ite,it6505"; > - interrupts = <152 IRQ_TYPE_EDGE_FALLING 152 0>; > + interrupts = <152 IRQ_TYPE_LEVEL_LOW 152 0>; > reg = <0x5c>; > pinctrl-names = "default"; > pinctrl-0 = <&it6505_pins>; I fail to see the need for this. The example shall describe the binding and is not necessarily a correct description of the HW. People should look in the dts file for the HW descriptions, not the binding examples. So I have dropped this patch. Sam > -- > 1.9.1