Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751668AbWEPQYT (ORCPT ); Tue, 16 May 2006 12:24:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751669AbWEPQYS (ORCPT ); Tue, 16 May 2006 12:24:18 -0400 Received: from mx1.suse.de ([195.135.220.2]:10146 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1751663AbWEPQYS (ORCPT ); Tue, 16 May 2006 12:24:18 -0400 From: Andreas Schwab To: James Morris Cc: Alexey Dobriyan , Andrew Morton , linux-kernel@vger.kernel.org, Stephen Smalley Subject: Re: [PATCH] selinux: endian fix References: <20060516152305.GI10143@mipter.zuzino.mipt.ru> X-Yow: It's so OBVIOUS!! Date: Tue, 16 May 2006 18:24:14 +0200 In-Reply-To: (James Morris's message of "Tue, 16 May 2006 11:54:04 -0400 (EDT)") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 23 James Morris writes: > On Tue, 16 May 2006, Alexey Dobriyan wrote: > >> Signed-off-by: Alexey Dobriyan > > Hmm, I'm certain this was tested (perhaps on a BE machine, though). ntohs and htons are identical operations. Either you swap or you don't, but there is only one way to swap a short. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/