Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932110AbWEPQee (ORCPT ); Tue, 16 May 2006 12:34:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932111AbWEPQee (ORCPT ); Tue, 16 May 2006 12:34:34 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:27575 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S932110AbWEPQee (ORCPT ); Tue, 16 May 2006 12:34:34 -0400 Date: Tue, 16 May 2006 17:34:26 +0100 From: Al Viro To: Andreas Schwab Cc: James Morris , Alexey Dobriyan , Andrew Morton , linux-kernel@vger.kernel.org, Stephen Smalley Subject: Re: [PATCH] selinux: endian fix Message-ID: <20060516163426.GF27946@ftp.linux.org.uk> References: <20060516152305.GI10143@mipter.zuzino.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 19 On Tue, May 16, 2006 at 06:24:14PM +0200, Andreas Schwab wrote: > James Morris writes: > > > On Tue, 16 May 2006, Alexey Dobriyan wrote: > > > >> Signed-off-by: Alexey Dobriyan > > > > Hmm, I'm certain this was tested (perhaps on a BE machine, though). > > ntohs and htons are identical operations. Either you swap or you don't, > but there is only one way to swap a short. Indeed, but that kind of crap still deserves a fix - same result, but use that kind of misuse is begging for bugs later on. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/