Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751858AbWEPQoQ (ORCPT ); Tue, 16 May 2006 12:44:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751867AbWEPQoP (ORCPT ); Tue, 16 May 2006 12:44:15 -0400 Received: from relay00.pair.com ([209.68.5.9]:24333 "HELO relay00.pair.com") by vger.kernel.org with SMTP id S1751858AbWEPQoP (ORCPT ); Tue, 16 May 2006 12:44:15 -0400 X-pair-Authenticated: 71.197.50.189 Date: Tue, 16 May 2006 11:44:13 -0500 (CDT) From: Chase Venters X-X-Sender: root@turbotaz.ourhouse To: Stas Sergeev cc: Andrew Morton , dtor_core@ameritech.net, vojtech@suse.cz, linux-kernel@vger.kernel.org Subject: Re: [patch] add input_enable_device() In-Reply-To: <4469FDF0.3020403@aknet.ru> Message-ID: References: <44670446.7080409@aknet.ru> <20060515143119.54b5aff8.akpm@osdl.org> <4469F709.4040605@aknet.ru> <20060516090324.66ea0ea6.akpm@osdl.org> <4469FDF0.3020403@aknet.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 44 On Tue, 16 May 2006, Stas Sergeev wrote: > Hello. > > Andrew Morton wrote: >> iirc it had to do with the pc-speaker driver, but I don't seem to be able >> to locate the original email. > OK, sorry, I haven't realized its important. > > --- > The patch below adds input_enable_device() and input_disable_device() > to the input subsystem, that allows to enable and disable the input > devices. The reason to have it, is the snd-pcsp PC-Speaker driver in > an ALSA tree that needs an ability to disable the pcspkr driver. > > Signed-off-by: Stas Sergeev > CC: Dmitry Torokhov > CC: Vojtech Pavlik > > > --- a/include/linux/input.h 2006-04-05 17:10:01.000000000 +0400 > +++ b/include/linux/input.h 2006-04-05 17:36:49.000000000 +0400 > @@ -878,7 +878,7 @@ > > struct pt_regs *regs; > int state; > - > + int disabled; > int sync; > > int abs[ABS_MAX + 1]; Why eat an entire word here? It seems we already have a "dynalloc" boolean/int... perhaps some of these things could be rolled up into a bitfield. Cheers, Chase - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/