Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp4605774pxa; Mon, 10 Aug 2020 13:19:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzf4KfnzxGLgyaPo+nKEOUaJ9M/P9bhbOyD/VZ4Cbx0WyiIhHEDDHWGgBjTHTif28otFS2 X-Received: by 2002:a17:906:3790:: with SMTP id n16mr22921257ejc.256.1597090766130; Mon, 10 Aug 2020 13:19:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597090766; cv=none; d=google.com; s=arc-20160816; b=CXWqsbbHkg7agFwOggePZjApwRAmqnLQBUFlFUm21O+KyFi+A+hA3KepalEpHq5cEz L6lb56CGXYcp3DQm/WR+q4Hhk92ogQ7rVlucbl2LfBXNCUif2IQNP2e6Ru8UBtlQhTre 5ET3sKDoewnMxdYaacGNeXHA/s/HywL7GYiQXJs3qnW38Tz/W+CrER9YZIBE9pWZwppM MUtt3KM/CmVgJbCtvgl7FNu0rW6apFJ3RNv9VAJDVLVNEExFagqtPrkKYM8KSU7Y4JHM 3mzw6eDSCX4+veAmrn3s2FL9QRD0FWN7b0bkZusEHaK+tjERCXU9Vs/ZFwsBI/kDIayb iMOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=zH/zS83czE+d1+Q2jJrEPMFkS6rW0BZiw6A+vsWCpgs=; b=P0qtVNNMzJG9onLzB7PIuRyS4xGbBpNir6F44tM2e5F09oSg6H7DQZa7BfP/tv7lxW xeZsAS5QWgoEQzQcHEwVpUSD0F2S5hJ9+V+wZpiiZRqwK4xvlcNpapoJBNui5A5YTzZ6 PC1wiEereTVOqPSQYzcNEq1aQmF1w/8s34T510dk0KIJwPieVzHPVpg2rJdHwX/QsRke GNND6ecvpnwcTlKPOQXwFkRN6gdeQtI0iRVbLGlFTT56sgZmfMqSLJ+O9LB2is6Yyuw5 Re4jhRIJv9I7lpP6RlSXg1cJmfyY/ATg1tiPrJ7+lL2j0bUcVzF1/YsuTEWP2VJc3qty uZmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UJItNacS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q22si10805258eds.346.2020.08.10.13.18.42; Mon, 10 Aug 2020 13:19:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UJItNacS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726453AbgHJUPc (ORCPT + 99 others); Mon, 10 Aug 2020 16:15:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbgHJUPc (ORCPT ); Mon, 10 Aug 2020 16:15:32 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2E35C061756 for ; Mon, 10 Aug 2020 13:15:31 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id v9so11030440ljk.6 for ; Mon, 10 Aug 2020 13:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zH/zS83czE+d1+Q2jJrEPMFkS6rW0BZiw6A+vsWCpgs=; b=UJItNacSqkOaOzh/p4kbdlpFRFZtsHip+7I6QhfhyOihUAmwrV6NKX+DWoayeujpJP mfB2qOMH104EEo/iYodN9z7EV+nAwQQPBsdV7mA/gtZfVtXT3rEfwSk5hjAPEVhJnBpB R/jMcTnPss+RFbsJJLY9hWP4Xc1tufhEdFaOOATpW3v9FylBhF+N8/fB5LGGYn39RHOM HFNjiKicwh0uwdvFh1BMQRW38wPGOLEQbDHkNQHBTuI6VXPZK0GI3/kszXhTKwHZ0zxU 7Mikw+J6BtmUe2sgTSz306ly0MfypsMX34x1glyeC4EG8+dvF1UxLnaCzfKAqYJYZgjG iRuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zH/zS83czE+d1+Q2jJrEPMFkS6rW0BZiw6A+vsWCpgs=; b=Ic3JCOBj2TdFxM127a9t5MIngwrjbSANS+96ElSew5d9hFNYx9Slav8boR9HS8ZdWE wngXCjrMzTaaCkiIUTQaJ67p/RRmXy4pxgsZ2+du3+K0hquf8GDTh0Aa5j8Z4rOLEI34 FHnxTldkZ5RZUbf3CfL/dHUlmuhIoaGVpSWwdo7P7DfxcQNQKyKD0APd+7a2Zn4NnQpa MHzpyB6Ld7ZurmfpsTxKV3wwXu0Wcq3PyHcTIXQH47lXn64NWAd5jJxrhvdlVs4OVj1Z NAdvh0ABEBq5KhPaXvdSwoV/hu/+jVN/CvXIUzzR4tY+Pq78EhEaSxH4+K3Xuxc05TQS jiYg== X-Gm-Message-State: AOAM533D5WJuPM+j694qXICFE3O3FsF6a41z0ZMFCxcuKu3Uvufdeu21 wtjzDDW7hUduPryiVRukP+gMdfLY X-Received: by 2002:a2e:990c:: with SMTP id v12mr1412040lji.449.1597090529427; Mon, 10 Aug 2020 13:15:29 -0700 (PDT) Received: from [192.168.2.145] (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.googlemail.com with ESMTPSA id h6sm11011029lfc.84.2020.08.10.13.15.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2020 13:15:28 -0700 (PDT) Subject: Re: regulator: deadlock vs memory reclaim To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: Mark Brown , Liam Girdwood , linux-kernel@vger.kernel.org References: From: Dmitry Osipenko Message-ID: <9a5c8ca6-2027-4d89-e290-6db564b99962@gmail.com> Date: Mon, 10 Aug 2020 23:15:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 10.08.2020 23:09, Michał Mirosław пишет: > At first I also thought so, but there's more. Below is a lockdep > complaint with your patch applied. I did a similar patch and then two more > (following) and that is still not enough (sysfs/debugfs do allocations, > too). Then it should be good to move the locking for init_coupling() like I suggested and use GFP_NOWAIT for the two other cases. It all could be a single small patch. Could you please check whether GFP_NOWAIT helps?