Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp4615272pxa; Mon, 10 Aug 2020 13:35:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyT6Tiyf6zUGyJY9gJbkcEkhHZspaJqV3ZNAz9A+P2sUlo7mcoLdHzk5f4GEgVK2Aoyp7qR X-Received: by 2002:aa7:d1cb:: with SMTP id g11mr22532658edp.26.1597091756160; Mon, 10 Aug 2020 13:35:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597091756; cv=none; d=google.com; s=arc-20160816; b=gJSyXvX9t7OmPHnrXz8THC9RlgmvuuggsI2B2v7T0ma8Ey9l9AgPl2cl168InHTrph d5tFykm+GZ1Oglpb1hBda0kuy+j/MkM7e99HHi20Car42kRSfNkmy8cPJ14BNu1Xoafz M0ZrMrON/L7QeaCufvZDqpV2M3QnMku3mf0RrIXpu36aXYJR8yMDXGQxxxOYSDKtSD/K PlvEVYG3mtMJPQO7uHU77Mn4DSKuwhcLYrWB1KvYh9/5EczrEiILJEaypOKLFkxa+TUV tM7nA24fZw9hVjbQeksol+yhSWa/A5MpTBOOmRllK98EMNzihFD11qGJ7q5Fb0HUNFCp D+/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=fi6y7Sa5SbnYmUqQlnDkyIhg+d6nJKBI1tgep4DAWjo=; b=rQDQBU+swWszMuDV+J/b5K9H20O1qdg4n+SAT5SVreZxCjLCMF3n2hh+h3Dom9lyay r0A/gvW+xQEdnB20RGxX1UZEbNqt2hVAo5VMxgou6sCZoiTDh6F8an9Czxf21ZAmzFmh HXFJdJyLXdKvHjt18Rg6NFHxbheBbfrmCmhn5DeUihiwik2XoJbPSITTFNoYyOuXiy6g dTTnHwQdh+py0KDKwOU/q4/iGwd5nwJHto1tetkrJtx3tZp815wrYguPqgEeTkiwzbt9 T1YzYjjAJb7c9U6bWmWF41UABJyvYUR0DjtglrTw/QMKpEuwdsuiWDBT3n2hd4v+CBO1 w/PQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=JOzJWw1g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w4si11559093ejb.443.2020.08.10.13.35.31; Mon, 10 Aug 2020 13:35:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=JOzJWw1g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726422AbgHJUeR (ORCPT + 99 others); Mon, 10 Aug 2020 16:34:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbgHJUeR (ORCPT ); Mon, 10 Aug 2020 16:34:17 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D557C061756 for ; Mon, 10 Aug 2020 13:34:17 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id mw10so674294pjb.2 for ; Mon, 10 Aug 2020 13:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fi6y7Sa5SbnYmUqQlnDkyIhg+d6nJKBI1tgep4DAWjo=; b=JOzJWw1gvAKYKaKRPYFB7PDEtf/ROnu9QV3IBnv1TSojh8rA4SQDXu2BYcVoFy3OG3 /1S7ceSeUOZRQj5/KJ883IHIaMTeO3M9J24kHva8cgaCR5Xo6aJNutKKgpikvs/JeoOS qD4csJ4Y75B50acWG/yL6J9pEBmybt7v8yqj1t99J8SeLMPb5fVjmpF3NEweDhwEol7+ 7doyqvmCBVIE/HEX/VvDC3/Fj8js2/F7BA9vATzSbiESOZLA5bGVxPf8otGpMHEeZ2cY 2Bvb4XNIcXVzWcv8UNp9R4bSO+yVHTbiq+zBUFC9KU2RWuyNhgX+FzYF2XEQnZDoadwL 4/2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fi6y7Sa5SbnYmUqQlnDkyIhg+d6nJKBI1tgep4DAWjo=; b=PjgldbCJ4mN7w0UUN6sd89NH6mXD5RxwJpNLMfN6gpeF7HlkbJmuT/l82J+615iKDY nlIosOCpQnsjPIX16IfzOpEMBP73J+iZUBmIEe9cblBoFINYOZJJsyPPMFWAw5s/j2Kk +GAfAhA1GKbzvg2pw9eu5FFDD1nVPaHCEmCCf8smWoN5UoEE+TWe6ppptVNV4+onYLc8 6s45orPHCmzXJJDK+dao1q/39rv8cnTH33h5OxN0+0dwYn7yV5dFxoVD6LCGmgg5YRD1 rb/1bII/RLkzQw8Y/NDGYmiGLuy9anumplUVik8EIXZlIQr5V5DIJT8NiUTnr9BEQEAh n25Q== X-Gm-Message-State: AOAM532aP7IW40Tfo8nr0HCn2MwhRTZ8sREnnVlhuTAGTbTd1YHqP4OQ FKDnXpPE4U6RvR3zW6j/XO3kcOExl9B/kaF1sjmGmg== X-Received: by 2002:a17:902:10f:: with SMTP id 15mr26409586plb.232.1597091656550; Mon, 10 Aug 2020 13:34:16 -0700 (PDT) MIME-Version: 1.0 References: <20200806203737.3636830-1-urielguajardojr@gmail.com> In-Reply-To: <20200806203737.3636830-1-urielguajardojr@gmail.com> From: Brendan Higgins Date: Mon, 10 Aug 2020 13:34:05 -0700 Message-ID: Subject: Re: [PATCH] kunit: added lockdep support To: Uriel Guajardo Cc: Uriel Guajardo , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 6, 2020 at 1:37 PM Uriel Guajardo wrote: > > From: Uriel Guajardo > > KUnit tests will now fail if lockdep detects an error during a test > case. > > The idea comes from how lib/locking-selftest [1] checks for lock errors: we > first if lock debugging is turned on. If not, an error must have > occurred, so we fail the test and restart lockdep for the next test case. > > Like the locking selftests, we also fix possible preemption count > corruption from lock bugs. > > Depends on kunit: support failure from dynamic analysis tools [2] > > [1] https://elixir.bootlin.com/linux/v5.7.12/source/lib/locking-selftest.c#L1137 > > [2] https://lore.kernel.org/linux-kselftest/20200806174326.3577537-1-urielguajardojr@gmail.com/ > > Signed-off-by: Uriel Guajardo Reviewed-by: Brendan Higgins