Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3485pxa;
        Mon, 10 Aug 2020 16:52:04 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzzan99piGtc3yokD4Tqba2+GtRUywbInVT8pJARaJ6zzA1eOJ7cDTLEEXP3yCeT1hcaz4o
X-Received: by 2002:a05:6402:c85:: with SMTP id cm5mr23973555edb.350.1597103524241;
        Mon, 10 Aug 2020 16:52:04 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1597103524; cv=none;
        d=google.com; s=arc-20160816;
        b=tfUoQSigX/3dEZ182VSL8lOeeDnaetxemuz6ARjGlpXEsHkQxvwilv0fZvhedKi8lO
         fKaKfeJWeKSsk5t4VoGpEIHeGCdEm8798qcsNhYT8wFaRqfjmcDY7mABkUvb2ITlmVez
         nS9/MBbV4Dw8H2VayycfCW8rm1ncw4juG1ayOry/jMNBG2JS9U25YeIlnX/4yuiTcgmM
         rCONSCdZkpiFZhwqZw2f/CcRMwjsxS914wvKJ3eHEsGLfDPXMSMkrzMAlNUKbn3ejraT
         W043qC0YPhauu4zoFmRRoCRJ5rXL1Eo+nfLc5l/sCfWfYVwjC0tPsb9EV3WuwFyZlOwV
         4H+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:ironport-sdr:ironport-sdr;
        bh=87vERp8Tkyhe8NwoCbVmoyZFsxMcGgXLfi1a39BT78I=;
        b=VkRSqRH3XNyt1mAY0GetJ50/+c1xvJL9BtV/GUUXQRadBLNvACU/L0CscsvmnPjXLv
         w1qwV+tC6yDPFOI7G/p5KLpxUDHY3eGz5x5BCNAQg/i/kMo6gDc5qoTeUUXJpXdXWDpp
         j05ykM2cNRc034mpmBaj0zd/+lXubh2q9cbhwbJQfqD/k/wbD72D/zX4GG00XOuBNOF4
         r4cD5dee4C13lfodVhruoDpmYTrcrDtdiLFbc5tbCc6Gdj0fxplWJvYmPcQgGid0lwTn
         gHpB3IxGzfXmTiSbhD5N83aZJou/ZU/3Ime5JeB0c4I8EGE3AhFLrgzhDuUUpOMYGrRX
         TM9g==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id f27si11557943ejj.255.2020.08.10.16.51.41;
        Mon, 10 Aug 2020 16:52:04 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727845AbgHJXsk (ORCPT <rfc822;ivid.suvarna@gmail.com>
        + 99 others); Mon, 10 Aug 2020 19:48:40 -0400
Received: from mga07.intel.com ([134.134.136.100]:48551 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726978AbgHJXsj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Aug 2020 19:48:39 -0400
IronPort-SDR: z3lwRyZA7YRybpY3dY4GFZepudjTzrEA+LvZ4/8Ai+p4JHKbGra4k4xXPGW2+NJ6b1G4Ighi/a
 KwanpFpEej8Q==
X-IronPort-AV: E=McAfee;i="6000,8403,9709"; a="217973005"
X-IronPort-AV: E=Sophos;i="5.75,458,1589266800"; 
   d="scan'208";a="217973005"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
  by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2020 16:48:38 -0700
IronPort-SDR: 8cgDxUS+J1VzRgt8O8sKhAzt0TsHWt7cPUUWJzbs+R17gBvfWk4vrdWtk7/qVtMmZ20AMoPCUc
 sVpfB1qa4UMQ==
X-IronPort-AV: E=Sophos;i="5.75,458,1589266800"; 
   d="scan'208";a="290520811"
Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.160])
  by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2020 16:48:38 -0700
Date:   Mon, 10 Aug 2020 16:48:37 -0700
From:   Sean Christopherson <sean.j.christopherson@intel.com>
To:     Andy Lutomirski <luto@kernel.org>
Cc:     Nathaniel McCallum <npmccallum@redhat.com>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        X86 ML <x86@kernel.org>, linux-sgx@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Jethro Beekman <jethro@fortanix.com>,
        Cedric Xing <cedric.xing@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        asapek@google.com, Borislav Petkov <bp@alien8.de>,
        chenalexchen@google.com, Conrad Parker <conradparker@google.com>,
        cyhanish@google.com, Dave Hansen <dave.hansen@intel.com>,
        "Huang, Haitao" <haitao.huang@intel.com>,
        Josh Triplett <josh@joshtriplett.org>,
        "Huang, Kai" <kai.huang@intel.com>,
        "Svahn, Kai" <kai.svahn@intel.com>, Keith Moyer <kmoy@google.com>,
        Christian Ludloff <ludloff@google.com>,
        Neil Horman <nhorman@redhat.com>,
        Patrick Uiterwijk <puiterwijk@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Thomas Gleixner <tglx@linutronix.de>, yaozhangx@google.com
Subject: Re: [PATCH v36 21/24] x86/vdso: Implement a vDSO for Intel SGX
 enclave call
Message-ID: <20200810234837.GH14724@linux.intel.com>
References: <20200716135303.276442-1-jarkko.sakkinen@linux.intel.com>
 <20200716135303.276442-22-jarkko.sakkinen@linux.intel.com>
 <CAOASepOqRfUafSv_qjUv-jW_6n8G7kZ9yh-2z_Z9sjL_2zqNCg@mail.gmail.com>
 <CALCETrVch_XW-oc_-LR8Dbgat9DpSKtCYTV9YZaU7tfu61FHEw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrVch_XW-oc_-LR8Dbgat9DpSKtCYTV9YZaU7tfu61FHEw@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 10, 2020 at 04:08:46PM -0700, Andy Lutomirski wrote:
> What am I missing?  I still don't really understand why we are
> supporting this mechanism at all.  Just the asm code to invoke the
> callback seems to be about half of the entire function.

Because the Intel SDK (and other SDKs?) wants to use the host stack to pass
parameters out of the enclave.