Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp68892pxa; Mon, 10 Aug 2020 19:01:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXO0xCwOprTuYDtwazuigCUsudA94dAt4jMl6XlgU5dkYOMN6ulBdsuWpD0SvhNYgYHHmI X-Received: by 2002:a17:906:ce37:: with SMTP id sd23mr25358866ejb.272.1597111266534; Mon, 10 Aug 2020 19:01:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597111266; cv=none; d=google.com; s=arc-20160816; b=NxaGyb3X/d3r3Zxu/jIYoKhLsr2PfaJeYYb4OHiTjEKehGqgNVluF5A9FmRus/FLCm hdX+Ok6im8O5qmz2Ky1tFtfB/x7vkCVAAv1Pgv4cJ2U33GCZ8j//zJLSzCFOVa+pP5/s Bq+o24MFLGXW0bxBAwioQ5g6ozoT73IEaBHjfSkk53cPqp6WEcO3SQpgUNLepVfUoyRm jaW9qREUviR95ahlnNJhOrA638LSNQZIKZ75Uuncy75uesswyjRDlg+pEWteXPKKG3LZ OUoooJSUlORX3eQJayxQ9SFW/rH+0s/5j8O8houd6SVg9LEcjHxFZ9nblm4QYue1Q6Mo /Q6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=o6qs2AUfyvscR1EJRzugc7bfggenhBjHgbJggcqkj/E=; b=bxxJ6mWk3mMVIO3PNdEsXkb7TeWL/rd0XkOL4AhonqyHuN3tn3H/h04vnz8SttAZHT E1djIh1r26kYhwYtMhwaJAnffV9uGM/Adg05hSsesE2374eTLOeEBLkemE+FH+BzYfVQ EWv0P0wX9Qszt4kuTnfKTot+KUKYMR8vPKBCwYK8CDYdF+hdaa9yHehd0ZlgmrhEvaA8 Mu8pFHVZRfOecHGeRN7q6aA7/MB6+nX2Tmta5W6CSRN8av7Xfejl75S1LVADiBSZ1r5y KdF4G9W06vh3DvWr4NuOfAMm8LYhr7ZuqWwQHdVaBpSGObJuxQeylhq9BQnXFuPWUJiR yrbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h11si12367432ejy.197.2020.08.10.19.00.43; Mon, 10 Aug 2020 19:01:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728064AbgHKCAK (ORCPT + 99 others); Mon, 10 Aug 2020 22:00:10 -0400 Received: from mail.loongson.cn ([114.242.206.163]:34216 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727989AbgHKCAK (ORCPT ); Mon, 10 Aug 2020 22:00:10 -0400 Received: from bogon.localdomain (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxT9+d+zFfTCoHAA--.3432S2; Tue, 11 Aug 2020 09:59:58 +0800 (CST) From: Kaige Li To: Sanjay R Mehta , Shyam Sundar S K , Jon Mason , Dave Jiang , Allen Hubbe Cc: linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org Subject: [RESEND] NTB: hw: amd: fix an issue about leak system resources Date: Tue, 11 Aug 2020 09:59:57 +0800 Message-Id: <1597111197-28563-1-git-send-email-likaige@loongson.cn> X-Mailer: git-send-email 2.1.0 X-CM-TRANSID: AQAAf9DxT9+d+zFfTCoHAA--.3432S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Xr4kWF18WFyrKFyftF13Arb_yoW3uFb_J3 43XrsYgr1ktF9xt3WSkr1avrWSvas0vrsrWFyktF9xuF4UWr47W3yUAFs5GF4Y9FWjvFy3 ur1qkFy5C3sIyjkaLaAFLSUrUUUUnb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbh8YjsxI4VWxJwAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4 vEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJwAaw2AFwI0_JF0_Jw1le2I262IYc4CY6c8Ij28I cVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jw0_WrylYx 0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCY 1x0262kKe7AKxVWUAVWUtwCY02Avz4vE14v_KwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4 IE7xkEbVWUJVW8JwCFI7km07C267AKxVWUAVWUtwC20s026c02F40E14v26r1j6r18MI8I 3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIx AIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAI cVCF04k26cxKx2IYs7xG6Fyj6rWUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87 Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxU4Vc_UUUUU X-CM-SenderInfo: 5olntxtjh6z05rqj20fqof0/ Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The related system resources were not released when pci_set_dma_mask(), pci_set_consistent_dma_mask(), or pci_iomap() return error in the amd_ntb_init_pci() function. Add pci_release_regions() to fix it. Signed-off-by: Kaige Li --- changed commit massage. drivers/ntb/hw/amd/ntb_hw_amd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ntb/hw/amd/ntb_hw_amd.c b/drivers/ntb/hw/amd/ntb_hw_amd.c index 88e1db6..71428d8 100644 --- a/drivers/ntb/hw/amd/ntb_hw_amd.c +++ b/drivers/ntb/hw/amd/ntb_hw_amd.c @@ -1203,6 +1203,7 @@ static int amd_ntb_init_pci(struct amd_ntb_dev *ndev, err_dma_mask: pci_clear_master(pdev); + pci_release_regions(pdev); err_pci_regions: pci_disable_device(pdev); err_pci_enable: -- 2.1.0