Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 3/4] MIPS: BCM63xx: enable EHCI for DWV-S0 board
To:     =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <f4bug@amsat.org>,
        =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= <noltari@gmail.com>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jonas Gorski <jonas.gorski@gmail.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20200807100411.2904279-1-noltari@gmail.com>
 <20200807100411.2904279-4-noltari@gmail.com>
 <CAAdtpL7+_inNrbDpq_wt1Eo=tU6+e+yYR9ox-BF7bN82HVV5_Q@mail.gmail.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <b1210ef6-36ec-9e3f-e686-a87244ea1c33@gmail.com>
Date:   Mon, 10 Aug 2020 19:33:45 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Firefox/68.0 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAAdtpL7+_inNrbDpq_wt1Eo=tU6+e+yYR9ox-BF7bN82HVV5_Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 8/9/2020 11:49 AM, Philippe Mathieu-Daudé wrote:
> Hi Álvaro,
> 
> On Fri, Aug 7, 2020 at 12:05 PM Álvaro Fernández Rojas
> <noltari@gmail.com> wrote:
>>
>> EHCI and OHCI share the same USB ports. Therefore, if the board has OHCI
>> it should also have EHCI.
> 
> This statement isn't correct. OHCI doesn't imply EHCI...
> (although the opposite is almost always true).
> 
> Now per 6358-PB01-R the bcm6358 indeed has a EHCI controller.
> 
> Do you mind rewording the commit description?

Is not it that a single USB port is used and we need the EHCI controller
active in order for the correct speed negotiation to occur?
-- 
Florian