Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp187769pxa; Mon, 10 Aug 2020 23:38:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyN5y+UrgzNL0BT1CbXoa1GOOFLlmhKJeljlawNlGZu/rQ6G5o1BFOhKtDAnmjnRmHZQLUS X-Received: by 2002:a17:906:401b:: with SMTP id v27mr24714707ejj.300.1597127908750; Mon, 10 Aug 2020 23:38:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597127908; cv=none; d=google.com; s=arc-20160816; b=TXPu6dATg+sP7nQDPegF6NiJbpM1TryeiZApVBvqLPpiKd/4q0cBJE+O6YsXYOuv+4 nl4KOO5xrklHfVpE7tMc9FXF8CCIjuO6l57LU2CbOABodxogNsY+FF9kE5988iUngE+2 7sW4ftJAiyg8V92kXsU4cTBD6wTftX/fA464Wc6p1KQFgs7gmQD9/JtxNPNCzCOIMFGE j4EI4c51W+f7PQsYbWliWnrygKOsfSB0KJuSmh/qbYHwjGWGND1UkRj5Vsv71bQdFZUd GWrdsb0sqD84VJ+Lq7pMw8GnnpnyU9j4qG0aDDXjs+uDu9WASQoVVzEHiSL/BjF1IUUL 4PzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=goH7JSZMWyIR+HDIVljDARSAieBgluozz9Jxq+R5Hyg=; b=eVovxiDELGnWkJKJ617fvPqFZvMKORV4/salvFnY69dMFPT8QNYxBPcCMgf5ZVBEUf RiBXmdt4DqwivDR9m+3FAaRMemxNiN5s8Bq9zu5//56xVZ57pqG7j3yth/PasgXqAH3T Up0J6FF8ut5QnhMwPoJZiS22n1dccyg5zgPfgVEJUtQBXEk9ONhXIHW9A47UQ8g51RlY G/HM5O/PSZahl7H+tURiz/FwTLHiIXMvbWWlDrRwwUc5xbcdBHi0UHCUfdMd27HfUb97 0fdJgBZG33YjnWggh1PVseVn6CuC/b0AcgzK97aw8fpYo0BtNDZxm3AXQZCW7f4EB8Ux wB2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aAf8vbUl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q22si11557193eds.346.2020.08.10.23.38.05; Mon, 10 Aug 2020 23:38:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aAf8vbUl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728095AbgHKGhY (ORCPT + 99 others); Tue, 11 Aug 2020 02:37:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727984AbgHKGhX (ORCPT ); Tue, 11 Aug 2020 02:37:23 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB177C061756 for ; Mon, 10 Aug 2020 23:37:22 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id c19so1446095wmd.1 for ; Mon, 10 Aug 2020 23:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=goH7JSZMWyIR+HDIVljDARSAieBgluozz9Jxq+R5Hyg=; b=aAf8vbUl+EWEbaY/2D3jfMw6IpePyjwma7LZ4Y7IB5uHpZD0WRrNqeMvJHS0eUziK7 xHj13IzFM/CeVFgZ0igTTezoxtpBYOsgLzzd4Vh5aGu7sYbk+nPSx1P8+dcWLL9kAC3n QtHKScoG+HSB6DjOKgeXV3W3NbmGuQ/Quw5U2+vXKeIIhbBAFaPS2rbFOIoBhocxEaSk haPP9WXOwbboXdrMV/8I820lZ0XKHFtfDc9o6u92x0IEDEs9XymYUi9id3r7Aj/TcDcZ gkOJWP3AaMOF0PJdm1347rwOPw321OLw1LgZ9yPoLxAtBAERzvcwWku9kgPc9vaIJ1Lq YTSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=goH7JSZMWyIR+HDIVljDARSAieBgluozz9Jxq+R5Hyg=; b=dcBoTffGLJhzdMuO7/tkYqQNNVzbUU9ZSZZhF3mlf59tRfCDFDDiWSISh3vQDkAwKW 0A4F76S3smJM9KDT6ytoKN+cX8aL2+jedgSD4Fv2n9vnZfeeh6DNNGwzOi1BnU/wDPT4 +BN74DgQyAg+PpRqtMfvN462xNOzODrKX5izCv2X2VP/gsjxo3DcIYual3hNMDVqMKmr e1LgW4+L1VkgM7DzSycjG/TDg49YUUJW6tvDrTOK7LDO0AIJcPj/sVtzNRO6OGWpEupW JfMihuCPhMmSZVoFvXjjsk85LRtBSoYv2j/jAiR0dtAxK0rPzN8QK8lhdMcemgvWut6x 5uKQ== X-Gm-Message-State: AOAM530ByMSMvO6jrUBlRB+BBwM2U9GXX/gdhLoqtK37ChFUWlLMwZIP Zo3b4spXsoRl0vVPPIoKG2EpmA== X-Received: by 2002:a1c:9a06:: with SMTP id c6mr2420473wme.23.1597127841580; Mon, 10 Aug 2020 23:37:21 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id i14sm28266124wrc.19.2020.08.10.23.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2020 23:37:21 -0700 (PDT) Date: Tue, 11 Aug 2020 07:37:19 +0100 From: Lee Jones To: Anson Huang Cc: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH V2 2/3] pwm: imx27: Use dev_err_probe() to simplify error handling Message-ID: <20200811063719.GE4411@dell> References: <1597127072-26365-1-git-send-email-Anson.Huang@nxp.com> <1597127072-26365-2-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1597127072-26365-2-git-send-email-Anson.Huang@nxp.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Aug 2020, Anson Huang wrote: > dev_err_probe() can reduce code size, uniform error handling and record the > defer probe reason etc., use it to simplify the code. > > Signed-off-by: Anson Huang > --- > changes since V1: > - remove redundant return value print. > --- > drivers/pwm/pwm-imx27.c | 25 ++++++------------------- > 1 file changed, 6 insertions(+), 19 deletions(-) Acked-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog