Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp237754pxa; Tue, 11 Aug 2020 01:24:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRMCGpT9ADfKxGbQUr1HXd4Y6JhisbbOfnEcp76SGRv7MSqWymkvz8V1ucs/0u33WLasal X-Received: by 2002:a17:907:2119:: with SMTP id qn25mr25130982ejb.278.1597134270666; Tue, 11 Aug 2020 01:24:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597134270; cv=none; d=google.com; s=arc-20160816; b=KuikXEafC5U3D7Ab9vkB4/+OtP2ypg+x/DpqxdPWxyZYUiOAeAVFWHMSmaKw9rOk+V DqRHpNAV0Z0b5ZdEufzjmDLze/kd0arIzjoH8VVTroNQ4ZeMwCvVuVhvm7D9Y4fUf5nh vSlrWu6eKyQLiL0t2b3sNKDK+idGVheLuvsqiaxUpQ+k/EfyQtL3A8fOLaY9y80K9XBP DVwqx6WPXNuaMa7ae2uGDmKNFeQMkis7nBtAbAyP3Tx/p0d2TYDAYQHY3zhWQArLFHxO iIm2I66oZWvN4mhKAnWJxKJcZgHom4y/W/ZLZm0qTLHe/uOZ9hlX89iH0reHIp7uuG1M xI6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=GBlFkGwJfBlCgHu1p3Qm6XUoDo9ZUcp0MMm1gsbcnOA=; b=IqV37cnfbLPzLOwNe+hvsX1KS+OwvnlkXr9WG8r/spYBGs9eRG8uVzaF71qqzMtv78 WKAatoeFpqJCqEWNwoPSg2UZ6qFKUh0Xhkxiqw3Yv0Zw6orXLfjcLttMjQLURBOIXMv6 FQ0DsZ5JPONKu9dcSx/5oSw67CZeTjftFmFo8XBLz9vNbJMkQg1Km0IfUBQqGIWxkiVN INEM3ECI0UIKUUufOI9Dla+ukjljUoEbWvPs5oayiQuavwWgWxHg98bPO8t0IvCYiQGW GluN8ayq6uufboppt9LLxRG4Oq4QDVEHNXdZ933W29Q+0+TNo3FeAFV013+OYlZo071L qXTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f1HE1+q1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t28si12928123edt.38.2020.08.11.01.24.07; Tue, 11 Aug 2020 01:24:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f1HE1+q1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728378AbgHKIXV (ORCPT + 99 others); Tue, 11 Aug 2020 04:23:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:45566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbgHKIXV (ORCPT ); Tue, 11 Aug 2020 04:23:21 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 76CA920678; Tue, 11 Aug 2020 08:23:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597134201; bh=05X/U1X1FmvLRP9StXB50QFn4807rniaSe6uYcy49QM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f1HE1+q140jJ+fPqVO9eDe4qgKMVRPd/jV8j4P++0m1IjqbkmmHzA93KGTMDdPmr1 Q3FaWbW5iL+MT3uvjxKL7WiP832KT+sfI7FMbfuBnJheaZZcDciZ+1xSHhKSWqTc+b vpKT/hYrw2AxJZ0TD094EUtF3+4T/YQ1yGqM10Qo= Date: Tue, 11 Aug 2020 10:23:30 +0200 From: Greg Kroah-Hartman To: Paras Sharma Cc: Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] serial: qcom_geni_serial: To correct QUP Version detection logic Message-ID: <20200811082330.GC113774@kroah.com> References: <1597131794-1076-1-git-send-email-parashar@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1597131794-1076-1-git-send-email-parashar@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 11, 2020 at 01:13:14PM +0530, Paras Sharma wrote: > The current implementation reduces the sampling rate by half > if qup HW version greater is than 2.5 by checking if the geni > SE major version is greater than 2 and geni SE minor version > is greater than 5. > > This implementation fails when the version is 3 or greater. > > Hence by adding the another check for geni SE major version, > this problem can be solved. > > Signed-off-by: Paras Sharma > --- > drivers/tty/serial/qcom_geni_serial.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Should this go to stable kernels? If so, how far back? What git commit id is this patch fixing? And if so, why not put a Fixes: tag on this as well? thanks, greg k-h