Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: EzjumHhA0vfJSzcWhrURY5AzS/N5Y4W+8omHF9qBJuQyM5E8PrtUG1tDZU9WRFCQ7GgtFSNLEy
 AQYITUjakcsg==
IronPort-SDR: 9zq5r3W0sHvV7xfmGV1CvrJkriUqsZ+mqJiUYv5GjpqQgGo5IZJgXzakXfOefWphenHKWQSh0L
 MlFQON98Va6Q==
Subject: Re: [PATCH v1 2/2] perf/core: Fake regs for leaked kernel samples
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     mingo@redhat.com, oleg@redhat.com, acme@kernel.org,
        jolsa@kernel.org, Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com,
        alexander.shishkin@linux.intel.com, mark.rutland@arm.com
References: <20200731025617.16243-1-yao.jin@linux.intel.com>
 <20200731025617.16243-2-yao.jin@linux.intel.com>
 <20200804114900.GI2657@hirez.programming.kicks-ass.net>
 <4c958d61-11a7-9f3e-9e7d-d733270144a1@linux.intel.com>
 <20200805124454.GP2657@hirez.programming.kicks-ass.net>
 <797aa4de-c618-f340-ad7b-cef38c96b035@linux.intel.com>
 <56957a58-6292-e075-8c30-6230450e3518@linux.intel.com>
 <20200811075924.GU3982@worktop.programming.kicks-ass.net>
From:   "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <dbc68bbf-b1a8-77ab-c89c-2d890a0382cc@linux.intel.com>
Date:   Tue, 11 Aug 2020 16:31:10 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200811075924.GU3982@worktop.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Peter,

On 8/11/2020 3:59 PM, Peter Zijlstra wrote:
> On Tue, Aug 11, 2020 at 03:50:43PM +0800, Jin, Yao wrote:
>> Could I post v2 which basically refers to your patch but removes some
>> conditions since I see some issues in test if we use these conditions.
>>
>>   1. Remove '!event->attr.exclude_hv || !event->attr.exclude_host ||
>>      !event->attr.exclude_guest' at the entry of sanitize_sample_regs().
>>
>>   2. Remove '!attr.exclude_hv || !attr.exclude_host || !attr.exclude_guest'
>>      at the perf_event_open syscall entry.
> 
> exclude_host, maybe -- due to the dodgy semantics of it, but the others
> should definitely be there.
> 

exclude_guest and exclude_hv are tricky too.

If we do 'perf record -e cycles:u' in both host and guest, we can see:

event->attr.exclude_guest = 0

thus sanitize_sample_regs() returns regs directly even if exclude_kernel = 1.

And in guest, exclude_hv = 0, it's out of my expectation too.

Thanks
Jin Yao