Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp249513pxa; Tue, 11 Aug 2020 01:50:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyR1Ks1um4OTX0q9RRcfYk5lpJmYtih8xeEqr8AlBTA5wo3FKo5e58sKwetYP0JJwg/Z3vW X-Received: by 2002:a17:907:7287:: with SMTP id dt7mr24650396ejc.224.1597135825082; Tue, 11 Aug 2020 01:50:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597135825; cv=none; d=google.com; s=arc-20160816; b=JH5JtGo+2/27At8VvUHnybw4BZV02M+UhpL6W7q09+KA2v6vTGBp0QNiG5PcsNFBuB hBNr7ka6M782HLTzRA0+MfYLq0cggeuMOdqoKEw0MNMlt2+HMPeAHBrNPxSZZ6Of7Dwx Ij3MoRTGzbEdtR9NSQWLBmd+wKFmqn4sgxPlWmWSDPowXLunaOPBaQ1AsZ0B0jO/Z5v8 2y+Ho2D1eW6ZwDUL0W6kv0GjT2H/55mSdmujIr7GBLPQbQuBIzh86vwNipOtFt05pwyA UoacPVWY/PYoRUPidkHXJWukWXBBGQyYuMub6S9f7oc9Xh0wM8TpENT3IeVHJ83re8Rf skJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :ironport-sdr:ironport-sdr; bh=hICD/VCpcx8uOzdco/H3ilLupxBYcugtk6RRjO7Z5FE=; b=ZWRCLNJIZv7zl31shEJXdbxSpAoAPvIMdeKT48fRtVob9bIGAJCgVsIHL9cvTNMi+y 8xduTaZp4WPB2hJTySXPHnBD6smLJK9iVQ4M6/3mqQ+qVQRfGePV7uy8zSPABzv/CO66 /gP/CzsXKq8hOSbxzLNEQ8e9feVaImsS2QePnRkEygvdSUTrOriKKiudZv7dzkzvjlqQ Xo57vQL+I1crjq31MP8mcBLiX/78Tdt5MjBbILW3t70+93Be4W/k3qFcX66v1a1il/0i nmiqmqYVsDZJ422VERHd69nkFEUMWVNNdmCo69Yma1+lQS2MHHQYobjtWSXHBxx1y0WG TtAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f9si12338373ejt.242.2020.08.11.01.50.01; Tue, 11 Aug 2020 01:50:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728391AbgHKItX (ORCPT + 99 others); Tue, 11 Aug 2020 04:49:23 -0400 Received: from mga06.intel.com ([134.134.136.31]:5597 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728301AbgHKItX (ORCPT ); Tue, 11 Aug 2020 04:49:23 -0400 IronPort-SDR: oBEgQenW7Xvw3xd945JvGpy2rB84uc15GwYzjNopmZJ/MOycshNV7nGXrzIngvVfLC3sYqQwZP XN5T4LuYC8sw== X-IronPort-AV: E=McAfee;i="6000,8403,9709"; a="215210977" X-IronPort-AV: E=Sophos;i="5.75,460,1589266800"; d="scan'208";a="215210977" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2020 01:49:21 -0700 IronPort-SDR: IjDMjOjtMt5NrsPQQQhQG5ppu9k/6vRzxFy9SnlCF1inWJL2ZuVvgbjwN5CxLjn+lOhn+EJU4K 9qcllnVS6xCQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,460,1589266800"; d="scan'208";a="276244986" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.170]) ([10.237.72.170]) by fmsmga007.fm.intel.com with ESMTP; 11 Aug 2020 01:49:20 -0700 Subject: Re: [PATCH] xhci: Do warm-reset when both CAS and XDEV_RESUME are set To: Kai-Heng Feng , mathias.nyman@intel.com Cc: Greg Kroah-Hartman , "open list:USB XHCI DRIVER" , open list References: <20200810140753.6639-1-kai.heng.feng@canonical.com> From: Mathias Nyman Openpgp: preference=signencrypt Autocrypt: addr=mathias.nyman@linux.intel.com; prefer-encrypt=mutual; keydata= mQINBFMB0ccBEADd+nZnZrFDsIjQtclVz6OsqFOQ6k0nQdveiDNeBuwyFYykkBpaGekoHZ6f lH4ogPZzQ+pzoJEMlRGXc881BIggKMCMH86fYJGfZKWdfpg9O6mqSxyEuvBHKe9eZCBKPvoC L2iwygtO8TcXXSCynvXSeZrOwqAlwnxWNRm4J2ikDck5S5R+Qie0ZLJIfaId1hELofWfuhy+ tOK0plFR0HgVVp8O7zWYT2ewNcgAzQrRbzidA3LNRfkL7jrzyAxDapuejuK8TMrFQT/wW53e uegnXcRJaibJD84RUJt+mJrn5BvZ0MYfyDSc1yHVO+aZcpNr+71yZBQVgVEI/AuEQ0+p9wpt O9Wt4zO2KT/R5lq2lSz1MYMJrtfFRKkqC6PsDSB4lGSgl91XbibK5poxrIouVO2g9Jabg04T MIPpVUlPme3mkYHLZUsboemRQp5/pxV4HTFR0xNBCmsidBICHOYAepCzNmfLhfo1EW2Uf+t4 L8IowAaoURKdgcR2ydUXjhACVEA/Ldtp3ftF4hTQ46Qhba/p4MUFtDAQ5yeA5vQVuspiwsqB BoL/298+V119JzM998d70Z1clqTc8fiGMXyVnFv92QKShDKyXpiisQn2rrJVWeXEIVoldh6+ J8M3vTwzetnvIKpoQdSFJ2qxOdQ8iYRtz36WYl7hhT3/hwkHuQARAQABtCdNYXRoaWFzIE55 bWFuIDxtYXRoaWFzLm55bWFuQGdtYWlsLmNvbT6JAjsEEwECACUCGwMGCwkIBwMCBhUIAgkK CwQWAgMBAh4BAheABQJTAeo1AhkBAAoJEFiDn/uYk8VJOdIP/jhA+RpIZ7rdUHFIYkHEKzHw tkwrJczGA5TyLgQaI8YTCTPSvdNHU9Rj19mkjhUO/9MKvwfoT2RFYqhkrtk0K92STDaBNXTL JIi4IHBqjXOyJ/dPADU0xiRVtCHWkBgjEgR7Wihr7McSdVpgupsaXhbZjXXgtR/N7PE0Wltz hAL2GAnMuIeJyXhIdIMLb+uyoydPCzKdH6znfu6Ox76XfGWBCqLBbvqPXvk4oH03jcdt+8UG 2nfSeti/To9ANRZIlSKGjddCGMa3xzjtTx9ryf1Xr0MnY5PeyNLexpgHp93sc1BKxKKtYaT0 lR6p0QEKeaZ70623oB7Sa2Ts4IytqUVxkQKRkJVWeQiPJ/dZYTK5uo15GaVwufuF8VTwnMkC 4l5X+NUYNAH1U1bpRtlT40aoLEUhWKAyVdowxW4yGCP3nL5E69tZQQgsag+OnxBa6f88j63u wxmOJGNXcwCerkCb+wUPwJzChSifFYmuV5l89LKHgSbv0WHSN9OLkuhJO+I9fsCNvro1Y7dT U/yq4aSVzjaqPT3yrnQkzVDxrYT54FLWO1ssFKAOlcfeWzqrT9QNcHIzHMQYf5c03Kyq3yMI Xi91hkw2uc/GuA2CZ8dUD3BZhUT1dm0igE9NViE1M7F5lHQONEr7MOCg1hcrkngY62V6vh0f RcDeV0ISwlZWuQINBFMB0ccBEACXKmWvojkaG+kh/yipMmqZTrCozsLeGitxJzo5hq9ev31N 2XpPGx4AGhpccbco63SygpVN2bOd0W62fJJoxGohtf/g0uVtRSuK43OTstoBPqyY/35+VnAV oA5cnfvtdx5kQPIL6LRcxmYKgN4/3+A7ejIxbOrjWFmbWCC+SgX6mzHHBrV0OMki8R+NnrNa NkUmMmosi7jBSKdoi9VqDqgQTJF/GftvmaZHqgmVJDWNrCv7UiorhesfIWPt1O/AIk9luxlE dHwkx5zkWa9CGYvV6LfP9BznendEoO3qYZ9IcUlW727Le80Q1oh69QnHoI8pODDBBTJvEq1h bOWcPm/DsNmDD8Rwr/msRmRyIoxjasFi5WkM/K/pzujICKeUcNGNsDsEDJC5TCmRO/TlvCvm 0X+vdfEJRZV6Z+QFBflK1asUz9QHFre5csG8MyVZkwTR9yUiKi3KiqQdaEu+LuDD2CGF5t68 xEl66Y6mwfyiISkkm3ETA4E8rVZP1rZQBBm83c5kJEDvs0A4zrhKIPTcI1smK+TWbyVyrZ/a mGYDrZzpF2N8DfuNSqOQkLHIOL3vuOyx3HPzS05lY3p+IIVmnPOEdZhMsNDIGmVorFyRWa4K uYjBP/W3E5p9e6TvDSDzqhLoY1RHfAIadM3I8kEx5wqco67VIgbIHHB9DbRcxQARAQABiQIf BBgBAgAJBQJTAdHHAhsMAAoJEFiDn/uYk8VJb7AQAK56tgX8V1Wa6RmZDmZ8dmBC7W8nsMRz PcKWiDSMIvTJT5bygMy1lf7gbHXm7fqezRtSfXAXr/OJqSA8LB2LWfThLyuuCvrdNsQNrI+3 D+hjHJjhW/4185y3EdmwwHcelixPg0X9EF+lHCltV/w29Pv3PiGDkoKxJrnOpnU6jrwiBebz eAYBfpSEvrCm4CR4hf+T6MdCs64UzZnNt0nxL8mLCCAGmq1iks9M4bZk+LG36QjCKGh8PDXz 9OsnJmCggptClgjTa7pO6040OW76pcVrP2rZrkjo/Ld/gvSc7yMO/m9sIYxLIsR2NDxMNpmE q/H7WO+2bRG0vMmsndxpEYS4WnuhKutoTA/goBEhtHu1fg5KC+WYXp9wZyTfeNPrL0L8F3N1 BCEYefp2JSZ/a355X6r2ROGSRgIIeYjAiSMgGAZMPEVsdvKsYw6BH17hDRzltNyIj5S0dIhb Gjynb3sXforM/GVbr4mnuxTdLXQYlj2EJ4O4f0tkLlADT7podzKSlSuZsLi2D+ohKxtP3U/r 42i8PBnX2oAV0UIkYk7Oel/3hr0+BP666SnTls9RJuoXc7R5XQVsomqXID6GmjwFQR5Wh/RE IJtkiDAsk37cfZ9d1kZ2gCQryTV9lmflSOB6AFZkOLuEVSC5qW8M/s6IGDfYXN12YJaZPptJ fiD/ Message-ID: <171f8ce9-2fdf-9b8b-9dfe-2b24e5a4b1a1@linux.intel.com> Date: Tue, 11 Aug 2020 11:52:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200810140753.6639-1-kai.heng.feng@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.8.2020 17.07, Kai-Heng Feng wrote: > Sometimes re-plugging a USB device during system sleep renders the device > useless: > [ 173.418345] xhci_hcd 0000:00:14.0: Get port status 2-4 read: 0x14203e2, return 0x10262 > ... > [ 176.496485] usb 2-4: Waited 2000ms for CONNECT > [ 176.496781] usb usb2-port4: status 0000.0262 after resume, -19 > [ 176.497103] usb 2-4: can't resume, status -19 > [ 176.497438] usb usb2-port4: logical disconnect > > Because PLS equals to XDEV_RESUME, xHCI driver reports U3 to usbcore, > despite of CAS bit is flagged. > > So proritize CAS over XDEV_RESUME to let usbcore handle warm-reset for > the port. > > Signed-off-by: Kai-Heng Feng > --- Thanks, nice catch. Adding to queue -Mathias