Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200807100411.2904279-1-noltari@gmail.com> <20200807100411.2904279-4-noltari@gmail.com>
 <CAAdtpL7+_inNrbDpq_wt1Eo=tU6+e+yYR9ox-BF7bN82HVV5_Q@mail.gmail.com> <b1210ef6-36ec-9e3f-e686-a87244ea1c33@gmail.com>
In-Reply-To: <b1210ef6-36ec-9e3f-e686-a87244ea1c33@gmail.com>
From:   =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= <f4bug@amsat.org>
Date:   Tue, 11 Aug 2020 11:09:20 +0200
Message-ID: <CAAdtpL7=oA-2f0CA8-d6o44jbd7VtBOSSJSGmQjitVT3e_WLZw@mail.gmail.com>
Subject: Re: [PATCH v2 3/4] MIPS: BCM63xx: enable EHCI for DWV-S0 board
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= <noltari@gmail.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Jonas Gorski <jonas.gorski@gmail.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Florian,

On Tue, Aug 11, 2020 at 4:33 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 8/9/2020 11:49 AM, Philippe Mathieu-Daudé wrote:
> > Hi Álvaro,
> >
> > On Fri, Aug 7, 2020 at 12:05 PM Álvaro Fernández Rojas
> > <noltari@gmail.com> wrote:
> >>
> >> EHCI and OHCI share the same USB ports. Therefore, if the board has OHCI
> >> it should also have EHCI.
> >
> > This statement isn't correct. OHCI doesn't imply EHCI...
> > (although the opposite is almost always true).
> >
> > Now per 6358-PB01-R the bcm6358 indeed has a EHCI controller.
> >
> > Do you mind rewording the commit description?
>
> Is not it that a single USB port is used and we need the EHCI controller
> active in order for the correct speed negotiation to occur?

Yes. What sounds odd is "if the board has OHCI it should also have EHCI."

This is true for this particular board because its chipset is a bcm6358,
but I'm worried it might later confuse other developers. For example the
bcm6348 has a OHCI controller, but that doesn't imply its port can be
used as EHCI.

Regards,

Phil.

> --
> Florian