Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp281927pxa; Tue, 11 Aug 2020 02:54:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxInOcMI1KS9fZ9fqMvN5NA86D7aJtyKyu8cXbQjKzoKscttmSOh3lYPUYp3OA5bNN+lhCY X-Received: by 2002:a05:6402:3088:: with SMTP id de8mr25128426edb.88.1597139669020; Tue, 11 Aug 2020 02:54:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597139669; cv=none; d=google.com; s=arc-20160816; b=iV9nhn/iErXJ/EmVxxbVzgBdFfrHjO29cJHb9OYRnyNwh7zXNsFV3AN62YQWkXCVz/ PDIqWi0kik2utwQDjIUkb5yyNfWFPP8NY544ibuHRV26483MPdpPTnFUVdD0XJF0lYE+ nd5It9lO2f6VlzY2GoFAyf3OxAnUVn6nVQyth1PzHaJW/xBlr4+nE4zGG8So6qmI23nq 38rLjW/xVarf4harBZKYuuCq1PS4zgVSzrwqK93EeU50GrUx5ZCPBkJHDTr7tNANVlL0 8eWb0sBWKZKUXVci7HfYdB1Xr0fNPsDKDWo5daKsTnkF82lqAvPPN5Yjrx4T1Fd8dTQD hpaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=34NxuTHuuaxlTrp0QBpYwXdJxhoYhWgkXsT79ACXhBI=; b=MKnlkX7nzCrBHCHmkC8crk9o0+ETCpabHISVjhQChrirliPrjbK172gdFW3nHFncUE fVI5IhMuoLt9lwhcEN+KG09U8zseWYaQHHE5v+7AUIDDaaev6FyCx6DX+cndiYKq9f4K qZcFjAorbi04jupQrNDvib+oX0v7NhcIt5bB78N6Y05OHK1H4Ev5x2CVsKNX81dCQb0d UQFVDZdH6fT7NPrIpEPfxGdzg2coa9WyC4e9RKj/qLvJdSyY1Qu5VMs6lF/ksp6mWaoV nct05H1qybo49eK8hcW60czaYj2dXmuboKffukMKzg9lqYJ9GhHjXi1jrEBxNd67+1kp fRlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linutronix.de header.s=2020 header.b="yXFv45j/"; dkim=neutral (no key) header.i=@vger.kernel.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu23si12130637edb.440.2020.08.11.02.54.05; Tue, 11 Aug 2020 02:54:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@linutronix.de header.s=2020 header.b="yXFv45j/"; dkim=neutral (no key) header.i=@vger.kernel.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728460AbgHKJxf (ORCPT + 99 others); Tue, 11 Aug 2020 05:53:35 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:56888 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728274AbgHKJxf (ORCPT ); Tue, 11 Aug 2020 05:53:35 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1597139612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=34NxuTHuuaxlTrp0QBpYwXdJxhoYhWgkXsT79ACXhBI=; b=yXFv45j/NkN12I89hPKrRRt3y6IsbXp2z30BW9LR1+SIMEFThp1pdeaQ4LM9L9tiAa69no OxF24BGPWPyOplVt5AYdHm0lzBQPC7WqiZBg7GprfATjSKTVoHqu7aZNMhwmN8VMuE7VzF PU4DBYxA9+atj4AOLidlBQ71941w/45ny6a9eL9yMvPKZHRm08ocVrwOr4tN6lc2EbCfi2 dFobLLI83Tl6TLwvgx01ezVcJ6H2SRevkfo3LB4VAsKYpsUY5bPf3nqv2pfT6ZqSxqVVCZ MUc+cyl80tzreWSxW2glFKK9WZ4rsz6Zwwl0yY+5FvSLfHBKxEcOyFg3+KRE+g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1597139612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=34NxuTHuuaxlTrp0QBpYwXdJxhoYhWgkXsT79ACXhBI=; b=neMWOMBKOlsGBQxKGobT2vLvpDelklSE+tFhByonXtY94FggYvZ0ZvmMgZA35XKqEp1WwM Hbwv0AiwaKv3KDAA== To: "Dey\, Megha" , Jason Gunthorpe , "gregkh\@linuxfoundation.org" Cc: Marc Zyngier , "Jiang\, Dave" , "vkoul\@kernel.org" , "bhelgaas\@google.com" , "rafael\@kernel.org" , "hpa\@zytor.com" , "alex.williamson\@redhat.com" , "Pan\, Jacob jun" , "Raj\, Ashok" , "Liu\, Yi L" , "Lu\, Baolu" , "Tian\, Kevin" , "Kumar\, Sanjay K" , "Luck\, Tony" , "Lin\, Jing" , "Williams\, Dan J" , "kwankhede\@nvidia.com" , "eric.auger\@redhat.com" , "parav\@mellanox.com" , "Hansen\, Dave" , "netanelg\@mellanox.com" , "shahafs\@mellanox.com" , "yan.y.zhao\@linux.intel.com" , "pbonzini\@redhat.com" , "Ortiz\, Samuel" , "Hossain\, Mona" , "dmaengine\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "x86\@kernel.org" , "linux-pci\@vger.kernel.org" , "kvm\@vger.kernel.org" , xen-devel@lists.xenproject.org, Boris Ostrovsky , Juergen Gross Subject: Re: [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI irq domain In-Reply-To: <87ft8uxjga.fsf@nanos> References: <87h7tcgbs2.fsf@nanos.tec.linutronix.de> <87ft8uxjga.fsf@nanos> Date: Tue, 11 Aug 2020 11:53:31 +0200 Message-ID: <87d03x5x0k.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas Gleixner writes: CC+: XEN folks > Thomas Gleixner writes: >> The infrastructure itself is not more than a thin wrapper around the >> existing msi domain infrastructure and might even share code with >> platform-msi. > > And the annoying fact that you need XEN support which opens another can > of worms... which needs some real cleanup first. x86 still does not associate the irq domain to devices at device discovery time, i.e. the device::msi_domain pointer is never populated. So to support this new fangled device MSI stuff we'd need yet more x86/xen specific arch_*msi_irqs() indirection and hackery, which is not going to happen. The right thing to do is to convert XEN MSI support over to proper irq domains. This allows to populate device::msi_domain which makes a lot of things simpler and also more consistent. Thanks, tglx