Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 11 Aug 2020 12:28:48 +0200
From:   David Sterba <dsterba@suse.cz>
To:     Nikolay Borisov <nborisov@suse.com>
Cc:     Pavel Machek <pavel@denx.de>, clm@fb.com, jbacik@fb.com,
        dsterba@suse.com, sashal@kernel.org, wqu@suse.com,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        jungyeon@gatech.edu, stable@kernel.org
Subject: Re: [PATCH] btrfs: fix error value in btrfs_get_extent
Message-ID: <20200811102848.GN2026@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov <nborisov@suse.com>,
        Pavel Machek <pavel@denx.de>, clm@fb.com, jbacik@fb.com,
        dsterba@suse.com, sashal@kernel.org, wqu@suse.com,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        jungyeon@gatech.edu, stable@kernel.org
References: <20200803093506.GA19472@amd>
 <4e88eb32-ac7d-f0cb-d089-ec197595bce9@suse.com>
 <c30a0a5e-dfd5-8bee-63f6-c93af9dc7eb6@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c30a0a5e-dfd5-8bee-63f6-c93af9dc7eb6@suse.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 03, 2020 at 12:50:31PM +0300, Nikolay Borisov wrote:
> On 3.08.20 г. 12:39 ч., Nikolay Borisov wrote:
> > On 3.08.20 г. 12:35 ч., Pavel Machek wrote:
> >> btrfs_get_extent() sets variable ret, but out: error path expect error
> >> to be in variable err. Fix that.
> >>
> >> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
> > 
> > Good catch, this also needs:
> > 
> > Fixes: 6bf9e4bd6a27 ("btrfs: inode: Verify inode mode to avoid NULL
> > pointer dereference")
> > 
> > Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> 
> Actually the reason this error got introduced in the first place and I
> missed it during the review is that the function is doing something
> rather counter-intuitive - it's using 'err' variable as a synonym for
> 'ret'. A better approach would be to simply remove 'err' from that
> function. I'm now authoring such a patch, nevertheless the issue still
> stands.

The expected pattern is to use 'ret' for function return value and add
other temporary variables instead of the err/ret switching, which can be
found in the oldish code still. So the cleanup is going to do the right
thing, thanks.