Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp353953pxa; Tue, 11 Aug 2020 04:55:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXFw/VDV6ZMnokYSAsBaEcMTMeA87kthNeP2xGKlfM23mNArKyKD7BOx9dl3wsu1GQU7Qs X-Received: by 2002:a50:ef0a:: with SMTP id m10mr26103772eds.226.1597146957025; Tue, 11 Aug 2020 04:55:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597146957; cv=none; d=google.com; s=arc-20160816; b=y0UA3ZSyPUCRmvriGux9wi+mew0DswH1cMgf8ssTYzdrDmS/gcUH8CgHuYIL1lfWk1 oz5v546lEKPgIQT8Y+J2fMNXNnuwIvyfO+GQwfNHOOnuQQckalb7tM7sCezvVgYYg9V3 bZBm98p3Sqs6jenQoD4jiAfAjjn4+WfIAX+8jh7RK34e4uCmbftmKVbNQOTb9Znq0gQE 2+TdfNG1Qry898sGq5wxOayUFwpewAyAgu81b+NjqY8jGF0d+HBc/TYfuY8QV56/Ms9W pdaRaaRlxZ8erbxL39MqkzCLWv4hYDHf0W15epjNgAk1CSc4Gn4CHISGmb6BTW5rURwJ aUHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=EF/5LweJC3eSiqwymX89UElCaUzZlWsR9mKy6qyzx/A=; b=V0Wkdpx+7xz54+YVYhDraEcU1isW4L93t9AkdhBue/1iK2MCDMz6g/i58m7/2t/Kpw bkWGq0dVgZmU1NIG4MWbjVmrJ4AzqbV1eA6RgFjJ4RisiAeBxgksZIJ5F0MIM/oF81aQ tYdXVBsXpdyuAFfPluciyosX82zMY9N8pajvkzDMFvYlPlk9VPY5+i/cr6/n2Hn857L9 4je8W710aud9yA9jHhgez5L/mjAVL7rW+GOPVTBKs8QoRZNKzk9S+AsVdoGdvm4ePUEC BZvWl/Mr7Kr/uv+5cK+/6RAYTyo/t7tPjqBkFqgHG1Id4EkvFxJDRPkifgTfN4XlICKH wYNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm3si14509278ejc.513.2020.08.11.04.55.33; Tue, 11 Aug 2020 04:55:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728856AbgHKLyb convert rfc822-to-8bit (ORCPT + 99 others); Tue, 11 Aug 2020 07:54:31 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3052 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728663AbgHKLyb (ORCPT ); Tue, 11 Aug 2020 07:54:31 -0400 Received: from dggeme752-chm.china.huawei.com (unknown [172.30.72.54]) by Forcepoint Email with ESMTP id ED2C23C5DDC4E34D64B4; Tue, 11 Aug 2020 19:54:28 +0800 (CST) Received: from dggeme753-chm.china.huawei.com (10.3.19.99) by dggeme752-chm.china.huawei.com (10.3.19.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Tue, 11 Aug 2020 19:54:28 +0800 Received: from dggeme753-chm.china.huawei.com ([10.7.64.70]) by dggeme753-chm.china.huawei.com ([10.7.64.70]) with mapi id 15.01.1913.007; Tue, 11 Aug 2020 19:54:28 +0800 From: linmiaohe To: Florian Westphal CC: "davem@davemloft.net" , "kuba@kernel.org" , "pshelar@ovn.org" , "martin.varghese@nokia.com" , "dcaratti@redhat.com" , "edumazet@google.com" , "steffen.klassert@secunet.com" , "pabeni@redhat.com" , "shmulik@metanetworks.com" , "kyk.segfault@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] net: eliminate meaningless memcpy to data in pskb_carve_inside_nonlinear() Thread-Topic: [PATCH] net: eliminate meaningless memcpy to data in pskb_carve_inside_nonlinear() Thread-Index: AdZv1br+L6bqa4jMT5W4+rGy9yynuw== Date: Tue, 11 Aug 2020 11:54:28 +0000 Message-ID: <4916edcf633b4f3290d8fde26167805c@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.176.252] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Florian Westphal wrote: >Miaohe Lin wrote: >> The skb_shared_info part of the data is assigned in the following loop. > >Where? > It's at the below for (i = 0; i < nfrags; i++) loop. But I missed something as Eric Dumazet pointed out. Sorry about it.