Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Eli Cohen <elic@nvidia.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
CC:     Jason Wang <jasowang@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "eli@mellanox.com" <eli@mellanox.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        Majd Dibbiny <majd@nvidia.com>,
        "Maor Dickman" <maord@nvidia.com>,
        Shahaf Shuler <shahafs@mellanox.com>,
        "Parav Pandit" <parav@mellanox.com>
Subject: RE: VDPA Debug/Statistics
Thread-Topic: VDPA Debug/Statistics
Thread-Index: AdZv0SSA/p/JVf9BSJCSJo3Lye0OEAAAhW8AAADKLnA=
Date:   Tue, 11 Aug 2020 11:58:23 +0000
Message-ID: <BN8PR12MB34259F2AE1FDAF2D40E48C5BAB450@BN8PR12MB3425.namprd12.prod.outlook.com>
References: <BN8PR12MB342559414BE03DFC992AD03DAB450@BN8PR12MB3425.namprd12.prod.outlook.com>
 <20200811073144-mutt-send-email-mst@kernel.org>
In-Reply-To: <20200811073144-mutt-send-email-mst@kernel.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 026cd186-1bf4-4009-e71a-08d83dedd97f
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2020 11:58:23.8017
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Sh1TaJTzGiy8CvE8uUte9TOYrCoCQpdTsHeDQ+GkJ6XGj8cuf+fZlK1bIAMc97Gm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3124
X-OriginatorOrg: Nvidia.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1597147092; bh=f6ZQZFJWx5F3kfEGWwVFTMFrnC4Q9OeREi5+g2wW5p8=;
        h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature:
         ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:
         Thread-Index:Date:Message-ID:References:In-Reply-To:
         Accept-Language:Content-Language:X-MS-Has-Attach:
         X-MS-TNEF-Correlator:authentication-results:x-originating-ip:
         x-ms-publictraffictype:x-ms-office365-filtering-correlation-id:
         x-ms-traffictypediagnostic:x-ld-processed:
         x-ms-exchange-transport-forked:x-microsoft-antispam-prvs:
         x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck:
         x-microsoft-antispam:x-microsoft-antispam-message-info:
         x-forefront-antispam-report:x-ms-exchange-antispam-messagedata:
         Content-Type:Content-Transfer-Encoding:MIME-Version:
         X-MS-Exchange-CrossTenant-AuthAs:
         X-MS-Exchange-CrossTenant-AuthSource:
         X-MS-Exchange-CrossTenant-Network-Message-Id:
         X-MS-Exchange-CrossTenant-originalarrivaltime:
         X-MS-Exchange-CrossTenant-fromentityheader:
         X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
         X-MS-Exchange-CrossTenant-userprincipalname:
         X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg;
        b=P3BLAikVvSqIO4qoEGqR+PzaHyg8fkItfWCpFRUPAiAdUGC/23op/TjdPeuOIfTry
         TfamnzXlZJ32YDtruH72hPOuxZhj169FHCyo3ijBA2kHCEi4HnNpbNbfG/wYKHUw46
         E3tOcrxihMCr/7jjWvniyA1pjPO/QnBscpPDsnyIipgr5dY6G8gWYT6rs/fkIfbLxD
         5/f1f2/LTwKcB424Mna6eJWNXgbwE77wXZW7Syfbs+k3DIziuMW8jbUqbzks+3hoz7
         R56NrpybVphvduVmzPVTwWGOwPQgRShYzkLfKxL+tnq8X+duGreosCgw0g1U3ESHZk
         ph5MLpq2haKZw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 11, 2020 at 11:26:20AM +0000, Eli Cohen wrote:
> Hi All
>=20
> Currently, the only statistics we get for a VDPA instance comes from the =
virtio_net device instance. Since VDPA involves hardware acceleration, ther=
e can be quite a lot of information that can be fetched from the underlying=
 device. Currently there is no generic method to fetch this information.
>=20
> One way of doing this can be to create a the host, a net device for=20
> each VDPA instance, and use it to get this information or do some=20
> configuration. Ethtool can be used in such a case
>=20
> I would like to hear what you think about this or maybe you have some oth=
er ideas to address this topic.
>=20
> Thanks,
> Eli

Something I'm not sure I understand is how are vdpa instances created on me=
llanox cards? There's a devlink command for that, is that right?
Can that be extended for stats?

Currently any VF will be probed as VDPA device. We're adding devlink suppor=
t but I am not sure if devlink is suitable for displaying statistics. We wi=
ll discuss internally but I wanted to know why you guys think.

--
MST