Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: doh5YiBaw+a6tPrHb7laUNE/N8Rbx3cVf8I83LPSpQB//hkuyy162jfCabmtuUHn/outJ5W98Q
 wvSJs8u1p1Ku1KYxTxzB2R9U2v7uMEEkFjKUjnGWR6UmUU+GNkbLg8pe6uZZlb5qQpBh0MLL+3
 qmJATghFtcejDQUh2Ey01NwjwgwgSzs4wNUHVGIDU3a1l3w7C6L9JDzZMVzefVqlyVEtdkhN5j
 w7SFhAIWyO6Ip/0IG8ZZWhihzbcBPAmKZEL7KSeEfvWFySU1/HnNmrYy1yYuxINwHJwH/fHjS/
 /SE=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Adrian Hunter <adrian.hunter@intel.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Venkat Gopalakrishnan <venkatg@codeaurora.org>,
        Can Guo <cang@codeaurora.org>
Subject: RE: [PATCH 1/2] scsi: ufs: Fix interrupt error message for shared
 interrupts
Thread-Topic: [PATCH 1/2] scsi: ufs: Fix interrupt error message for shared
 interrupts
Thread-Index: AQHWbx4HOuqfYrnFSkanGiAtl5Qaa6ky1Mdw
Date:   Tue, 11 Aug 2020 12:20:26 +0000
Message-ID: <SN6PR04MB4640A7618C2425D6E837C20EFC450@SN6PR04MB4640.namprd04.prod.outlook.com>
References: <20200810135548.28213-1-adrian.hunter@intel.com>
In-Reply-To: <20200810135548.28213-1-adrian.hunter@intel.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: aa4daf5d-8800-4db7-9bca-08d83df0ee19
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2020 12:20:26.7776
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0SRt6lM3+nHYCcdzBphOmA5f1FZ8+Rwaw1/rP76ckDjs35W7aYCxU1eVdidQyv7gmGcFeJVrfZnMtVUwZc8LBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR04MB2351
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> The interrupt might be shared, in which case it is not an error for the
> interrupt handler to be called when the interrupt status is zero, so
> remove the message print and register dump.
>=20
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> Fixes: 9333d77573485 ("scsi: ufs: Fix irq return code")
> ---
>  drivers/scsi/ufs/ufshcd.c | 6 ------
>  1 file changed, 6 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index cdcf56679b41..d7522dba4dcf 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -5994,12 +5994,6 @@ static irqreturn_t ufshcd_intr(int irq, void *__hb=
a)
>                 intr_status =3D ufshcd_readl(hba, REG_INTERRUPT_STATUS);
>         } while (intr_status && --retries);
>=20
> -       if (retval =3D=3D IRQ_NONE) {
Maybe    if (enabled_intr_status && retval =3D=3D IRQ_NONE) { ?

Thanks,
Avri