Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] driver core: Let dev_err_probe() use the symbolic error
 code
To:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Mark Brown <broonie@kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     kernel@pengutronix.de, linux-kernel@vger.kernel.org
From:   Andrzej Hajda <a.hajda@samsung.com>
Message-ID: <432e6dce-f5ca-3fdd-7e24-5e343c430eab@samsung.com>
Date:   Tue, 11 Aug 2020 17:06:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
        Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200811072036.4596-1-u.kleine-koenig@pengutronix.de>
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20200811072058eucas1p18f846c1fb01f2dc91c2bd74091ce05cd@eucas1p1.samsung.com>
        <20200811072036.4596-1-u.kleine-koenig@pengutronix.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Uwe,

On 11.08.2020 09:20, Uwe Kleine-König wrote:
> This makes the error message:
>
> 	error -EIO: ...
>
> instead of
>
> 	error -5: ...
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>   drivers/base/core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index ac1046a382bc..33734d8831c7 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -4237,10 +4237,10 @@ int dev_err_probe(const struct device *dev, int err, const char *fmt, ...)
>   	vaf.va = &args;
>   
>   	if (err != -EPROBE_DEFER) {
> -		dev_err(dev, "error %d: %pV", err, &vaf);
> +		dev_err(dev, "error %pE: %pV", ERR_PTR(err), &vaf);
>   	} else {
>   		device_set_deferred_probe_reason(dev, &vaf);
> -		dev_dbg(dev, "error %d: %pV", err, &vaf);
> +		dev_dbg(dev, "error %pE: %pV", ERR_PTR(err), &vaf);


Apparently I have misread docs about %pE flag. Thanks for spotting this.

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

Regards
Andrzej


>   	}
>   
>   	va_end(args);