Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 11 Aug 2020 17:27:38 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To:     peterz@infradead.org
Cc:     Jessica Yu <jeyu@kernel.org>, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, keescook@chromium.org,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Miroslav Benes <mbenes@suse.cz>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2] module: Harden STRICT_MODULE_RWX
Message-ID: <20200811172738.2d632a09@coco.lan>
In-Reply-To: <20200811145524.GE2674@hirez.programming.kicks-ass.net>
References: <20200403171303.GK20760@hirez.programming.kicks-ass.net>
        <20200808101222.5103093e@coco.lan>
        <20200810092523.GA8612@linux-8ccs>
        <20200810150647.GB8612@linux-8ccs>
        <20200811163427.6edbf343@coco.lan>
        <20200811145524.GE2674@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Tue, 11 Aug 2020 16:55:24 +0200
peterz@infradead.org escreveu:

> On Tue, Aug 11, 2020 at 04:34:27PM +0200, Mauro Carvalho Chehab wrote:
> >   [33] .plt              PROGBITS         0000000000000340  00035c80
> >        0000000000000001  0000000000000000 WAX       0     0     1
> >   [34] .init.plt         NOBITS           0000000000000341  00035c81
> >        0000000000000001  0000000000000000  WA       0     0     1
> >   [35] .text.ftrace[...] PROGBITS         0000000000000342  00035c81
> >        0000000000000001  0000000000000000 WAX       0     0     1  
> 
> .plt and .text.ftrace_tramplines are buggered.
> 
> arch/arm64/kernel/module.lds even marks then as NOLOAD.

Hmm... Shouldn't the code at module_enforce_rwx_sections() or at
load_module() ignore such sections instead of just rejecting probing
all modules?

I mean, if the existing toolchain is not capable of excluding
those sections, either the STRICT_MODULE_RWX hardening should be
disabled, if a broken toolchain is detected or some runtime code 
should handle such sections on a different way.

Thanks,
Mauro