Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 11 Aug 2020 09:01:20 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     ira.weiny@intel.com
Cc:     Boris Pismenny <borisp@mellanox.com>,
        Aviad Yehezkel <aviadye@mellanox.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "David S. Miller" <davem@davemloft.net>,
        Ilya Lesokhin <ilyal@mellanox.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/tls: Fix kmap usage
Message-ID: <20200811090120.4c122255@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200811000258.2797151-1-ira.weiny@intel.com>
References: <20200811000258.2797151-1-ira.weiny@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 10 Aug 2020 17:02:58 -0700 ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> When MSG_OOB is specified to tls_device_sendpage() the mapped page is
> never unmapped.

Nice catch!

> Hold off mapping the page until after the flags are checked and the page
> is actually needed.

We could take the kmap/kunmap from under the socket lock, but that'd
perhaps be more code reshuffling than we need in a fix.

Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure")
Reviewed-by: Jakub Kicinski <kuba@kernel.org>