Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 11 Aug 2020 19:59:12 +0200
From:   peterz@infradead.org
To:     Jessica Yu <jeyu@kernel.org>
Cc:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        keescook@chromium.org, Josh Poimboeuf <jpoimboe@redhat.com>,
        Miroslav Benes <mbenes@suse.cz>,
        Mark Rutland <mark.rutland@arm.com>,
        Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v2] module: Harden STRICT_MODULE_RWX
Message-ID: <20200811175912.GF2674@hirez.programming.kicks-ass.net>
References: <20200403171303.GK20760@hirez.programming.kicks-ass.net>
 <20200808101222.5103093e@coco.lan>
 <20200810092523.GA8612@linux-8ccs>
 <20200810150647.GB8612@linux-8ccs>
 <20200811163427.6edbf343@coco.lan>
 <20200811145524.GE2674@hirez.programming.kicks-ass.net>
 <20200811172738.2d632a09@coco.lan>
 <20200811160134.GA13652@linux-8ccs>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200811160134.GA13652@linux-8ccs>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Aug 11, 2020 at 06:01:35PM +0200, Jessica Yu wrote:

> > > On Tue, Aug 11, 2020 at 04:34:27PM +0200, Mauro Carvalho Chehab wrote:
> > > >   [33] .plt              PROGBITS         0000000000000340  00035c80
> > > >        0000000000000001  0000000000000000 WAX       0     0     1
> > > >   [34] .init.plt         NOBITS           0000000000000341  00035c81
> > > >        0000000000000001  0000000000000000  WA       0     0     1
> > > >   [35] .text.ftrace[...] PROGBITS         0000000000000342  00035c81
> > > >        0000000000000001  0000000000000000 WAX       0     0     1

> Interesting, my cross-compiled modules do not have the executable flag -
> 
>  [38] .plt              NOBITS           0000000000000340  00038fc0
>       0000000000000001  0000000000000000  WA       0     0     1
>  [39] .init.plt         NOBITS           0000000000000341  00038fc0
>       0000000000000001  0000000000000000  WA       0     0     1
>  [40] .text.ftrace_tram NOBITS           0000000000000342  00038fc0
>       0000000000000001  0000000000000000  WA       0     0     1

> I'm a bit confused about what NOLOAD actually implies in this context. From the
> ld documentation - "The `(NOLOAD)' directive will mark a section to not be
> loaded at run time." But these sections are marked SHF_ALLOC and are referenced
> to in the module plt code. Or does it just tell the linker to not initialize it?

Yeah, that confusion is wide-spread, so much so that bfd-ld and gold,
both in bintils, had different behaviour at some point.

Anyway, another clue is that your build has all NOBITS, while Mauro's
build has PROGBITS for the broken sections.

Anyway, my gcc-10.1/binutils-2.34 cross tool chain (from k.org)
generates the same as Jessica's too. I wonder if binutils-2.35 is
wonky...