Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 11 Aug 2020 21:17:04 +0200
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Vinay Simha B N <simhavcs@gmail.com>
Cc:     Vinay Simha B N <simhavcs@gmail.com>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        Jonas Karlman <jonas@kwiboo.se>,
        David Airlie <airlied@linux.ie>,
        Neil Armstrong <narmstrong@baylibre.com>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
        Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver
Message-ID: <20200811191704.GA524675@ravnborg.org>
References: <1594388491-15129-1-git-send-email-simhavcs@gmail.com>
 <1594388491-15129-2-git-send-email-simhavcs@gmail.com>
 <CAGWqDJ4P9dKzGngkiEtL_X1HRjjtU17WqNFM-qiv16tXwQNZTg@mail.gmail.com>
 <CAGWqDJ4s3x5M7dGMTxYMpDbM4NBS7kfTb6-+7Fdx8Pe=CE58fA@mail.gmail.com>
 <20200808213022.GW6186@pendragon.ideasonboard.com>
 <20200810175440.GC292825@ravnborg.org>
 <20200811101942.GB6054@pendragon.ideasonboard.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200811101942.GB6054@pendragon.ideasonboard.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Vinay.

> > 
> > If Laurent or others identify further things to improve we can take
> > it in-tree.
> 
> Just one thing, please see below.
> 
> > > > >> +       d2l_write(tc->i2c, VTIM1, vtime1);
> > > > >> +       d2l_write(tc->i2c, HTIM2, htime2);
> > > > >> +       d2l_write(tc->i2c, VTIM2, vtime2);
> > > > >> +
> > > > >> +       d2l_write(tc->i2c, VFUEN, VFUEN_EN);
> > > > >> +       d2l_write(tc->i2c, SYSRST, SYS_RST_LCD);
> > > > >> +       d2l_write(tc->i2c, LVPHY0, LV_PHY0_PRBS_ON(4) | LV_PHY0_ND(6));
> > > > >> +
> > > > >> +       dev_dbg(tc->dev, "bus_formats %04x bpc %d\n",
> > > > >> +               connector->display_info.bus_formats[0],
> > > > >> +               tc->bpc);
> > > > >> +       /*
> > > > >> +        * Default hardware register settings of tc358775 configured
> > > > >> +        * with MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA jeida-24 format
> > > > >> +        */
> > > > >> +       if (connector->display_info.bus_formats[0] ==
> > > > >> +               MEDIA_BUS_FMT_RGB888_1X7X4_SPWG) {
> 
> This shouldn't come from the connector, but from the
> drm_bridge_state.output_bus_cfg.format. The drm_bridge_funcs
> .atomic_get_input_bus_fmts() operation likely needs to be implemented.

I trust you will look into this and submit a patch on top of
drm-misc-next.
Please add a proper "Fixes:" tag identifying the commit that introduced
this bug - in this case the commit introducing the driver.

Do not hesitate to reply to all if you have any questions.
We will help you if we can.

	Sam