Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <20200810010009.92758-1-arch0.zheng@gmail.com> <jhjwo26gxlb.mognet@arm.com> <9425382c-2a42-57ca-512d-c93c589dc701@gmail.com> <jhjv9hph3h7.mognet@arm.com> <01fe6a9b-fd3a-9b36-b2fa-6cea58415670@gmail.com> <jhjtux9gxh2.mognet@arm.com> <905d8887-e79c-daf6-cbce-80fd0509e37d@gmail.com>
User-agent: mu4e 0.9.17; emacs 26.3
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     Qi Zheng <arch0.zheng@gmail.com>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/fair: Remove the duplicate check from group_has_capacity()
In-reply-to: <905d8887-e79c-daf6-cbce-80fd0509e37d@gmail.com>
Date:   Tue, 11 Aug 2020 21:16:26 +0100
Message-ID: <jhjv9hp546d.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/08/20 14:12, Qi Zheng wrote:
> On 2020/8/11 下午8:48, Valentin Schneider wrote:
>> On 11/08/20 12:44, Qi Zheng wrote:
>>> In fact, at the beginning, I added unlikely() here to hint the compiler:
>>>
>>> -	if ((sgs->group_capacity * imbalance_pct) <
>>> -			(sgs->group_runnable * 100))
>>> +	if (unlikely((sgs->group_capacity * imbalance_pct) <
>>> +			(sgs->group_runnable * 100)))
>>>
>>> The corresponding patch is as follows:
>>>
>>>        [PATCH]sched/core: add unlikely in group_has_capacity()
>>>
>>> Do you think it is necessary?
>>
>> The "unlikely" approach has the benefit of keeping all corner cases in
>> place. I was tempted to say it could still make sense to get rid of the
>> extra check entirely, given that it has an impact only when:
>>
>> - sum_nr_running == group_weight
>> - group capacity has been noticeably reduced
>>
>> If sum_nr_running < group_weight, we won't evaluate it.
>> If sum_nr_running > group_weight, we either won't call into
>>    group_has_capacity() or we'll have checked it already in
>>    group_overloaded().
>>
>> That said, it does make very much sense to check it in that ==
>> case. Vincent might have a different take on this, but right now I'd say
>> the unlikely approach is the safest one of the two.
>>
>
> So what should I do next? Do I resubmit a patch with unlikely() or
> add your email to the old patch([PATCH]sched/core: add unlikely in
> group_has_capacity())? Or continue to wait for suggestions from
> other maintainers?

I guess you can add a reply to the original thread where you had the
unlikely() to point out *removing* the check isn't 100% harmless.

Vincent might want to have a look at it, but AFAIA he's on holidays ATM.