Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Andi Kleen' <ak@linux.intel.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Ingo Molnar <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        "alexey.budankov@linux.intel.com" <alexey.budankov@linux.intel.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>
Subject: RE: [PATCH 1/2] perf: Add closing sibling events' file descriptors
Thread-Topic: [PATCH 1/2] perf: Add closing sibling events' file descriptors
Thread-Index: AQHWb+1snIoIlGwKoUSHzUM68Tmsxaky+9RQgAAnAgCAAEM5sA==
Date:   Tue, 11 Aug 2020 21:06:23 +0000
Message-ID: <457dfe5709e642bd9b462f4c36e8ed75@AcuMS.aculab.com>
References: <20200708151635.81239-1-alexander.shishkin@linux.intel.com>
 <20200708151635.81239-2-alexander.shishkin@linux.intel.com>
 <20200806083530.GV2674@hirez.programming.kicks-ass.net>
 <20200806153205.GA1448395@tassilo.jf.intel.com>
 <875z9q1u3g.fsf@ashishki-desk.ger.corp.intel.com>
 <20200810144518.GB1448395@tassilo.jf.intel.com>
 <20200810203632.GF3982@worktop.programming.kicks-ass.net>
 <20200811142955.GC1448395@tassilo.jf.intel.com>
 <9ff26c5231954e65bbd4873d54ebd727@AcuMS.aculab.com>
 <20200811180334.GH1448395@tassilo.jf.intel.com>
In-Reply-To: <20200811180334.GH1448395@tassilo.jf.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> On Tue, Aug 11, 2020 at 02:47:03PM +0000, David Laight wrote:
> > From: Andi Kleen
> > > On Mon, Aug 10, 2020 at 10:36:32PM +0200, Peter Zijlstra wrote:
> > > > On Mon, Aug 10, 2020 at 07:45:18AM -0700, Andi Kleen wrote:
> > > >
> > > > > Unfortunately we're kind of stuck with the old NFILE=1024 default
> > > > > even though it makes little sense on modern servers.
> > > >
> > > > Why can't that be changed? It seems to me all of userspace changes all
> > > > the time; heck that system-doofus thing flushed 20+ years of sysadmin
> > > > experience down the drain, just cause. Why can't we up a file limit?
> > >
> > > We could try, but I believe it's hard coded in various places outside
> > > the kernel.
> >
> > The place it really bites is select().
> > Although the kernel supports large bitmaps glibc doesn't.
> > The random bit overwrites are a PITA to debug.
> 
> Good point.
> 
> I remember I asked for a simple define to increase like glibc5 had, but
> they still didn't implement that.

Even windows lets you redefine FDSET_SIZE before including the header.
And their select() is much more like poll() - so the limit is the number
of sockets, not the highest socket number (which do happen to be small
integers).

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)