Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 11 Aug 2020 14:40:14 -0700 (PDT)
From:   David Rientjes <rientjes@google.com>
To:     Abel Wu <wuyun.wu@huawei.com>
cc:     Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        hewenliang4@huawei.com, hushiyuan@huawei.com,
        "open list:SLAB ALLOCATOR" <linux-mm@kvack.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/slub: fix missing ALLOC_SLOWPATH stat when bulk
 alloc
In-Reply-To: <20200811022427.1363-1-wuyun.wu@huawei.com>
Message-ID: <alpine.DEB.2.23.453.2008111435300.3428139@chino.kir.corp.google.com>
References: <20200811022427.1363-1-wuyun.wu@huawei.com>
User-Agent: Alpine 2.23 (DEB 453 2020-06-18)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 11 Aug 2020, wuyun.wu@huawei.com wrote:

> From: Abel Wu <wuyun.wu@huawei.com>
> 
> The ALLOC_SLOWPATH statistics is missing in bulk allocation now.
> Fix it by doing statistics in alloc slow path.
> 
> Signed-off-by: Abel Wu <wuyun.wu@huawei.com>
> ---
>  mm/slub.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index df93a5a0e9a4..5d89e4064f83 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2600,6 +2600,8 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node,
>  	void *freelist;
>  	struct page *page;
>  
> +	stat(s, ALLOC_SLOWPATH);
> +
>  	page = c->page;
>  	if (!page) {
>  		/*
> @@ -2788,7 +2790,6 @@ static __always_inline void *slab_alloc_node(struct kmem_cache *s,
>  	page = c->page;
>  	if (unlikely(!object || !node_match(page, node))) {
>  		object = __slab_alloc(s, gfpflags, node, addr, c);
> -		stat(s, ALLOC_SLOWPATH);
>  	} else {
>  		void *next_object = get_freepointer_safe(s, object);
>  

Acked-by: David Rientjes <rientjes@google.com>

> -- 
> 2.28.0.windows.1

Lol :)