Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp768819pxa; Tue, 11 Aug 2020 14:48:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOVZiSUXLbeSkczuDyFT8gRM0mj2ZvNyZS9iNXZnyPGrrKgHeDqinKAYsnQ7++HFtWH6EU X-Received: by 2002:a17:906:7a16:: with SMTP id d22mr29014847ejo.478.1597182526196; Tue, 11 Aug 2020 14:48:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597182526; cv=none; d=google.com; s=arc-20160816; b=YfAZuVcXcSZFOmGpCdzYAF4D2CyheWCTulRCIE97jjo7yXLboYpfuZATVSKFpoZKPI PKlW6h4AYLtKviQRTsvlCnf+3huY1FLC5tR1bs/c07ifZxhE5PgyThk18VHdQ2udSQAz Gx+32nI7zwJpHFD7UxUQNIWAfieGNpRC99jsIHfovMJxKXTtYFocpsFYdnql6xJDRIu7 jnxjk8jky+yDFMvynKZ4cVwHW75+krL9vDGu0+Tx8xoP0O48J7GJuaaJWqkeb9jL2jqS pUoZKCiX0huMMCZ5RSUyqvuU8C6IZ/g/fDxaVeMi2Okhz0s8fP2AIHA4Azn5Gl5xW/sE oEtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=ekEmY1/ax+L0gbL+grpGSGz9Q9IPbEokzoRjtsOxC1U=; b=KqgWgLZUr6b/utozxye3LEj2mRxtsnc4zMMCsAXcBNYd3MYV7S6SpkIUx623rN3AR/ ls3k6LIEiQfBcpjp0kEx4RS83g4hzlJvsRECDz7bTXVS7g3v4VijQxedo38i/ATb6ncM 8KSPsbBS4QkQYQ+qtPVGSHtkTJuEt1rypXFzDlxTkJERcSC+pv/Jr6qq3PflXcn70b5k k/ARiEj0q7JETdwkEY04eIyAjkWUv3QOLnXJhOYprmIDvxRZ9EOjGn3kNbIMz1nNhPRB +QOlz5Fl6FoChf3QHdE3P/a0/k/dZkv0EEwFWUfhf+v84JTvQG5eF2UVP5qNrohEF28i jZtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=i5aLZDzI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k17si1427eds.353.2020.08.11.14.48.22; Tue, 11 Aug 2020 14:48:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=i5aLZDzI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726271AbgHKVqL (ORCPT + 99 others); Tue, 11 Aug 2020 17:46:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgHKVqL (ORCPT ); Tue, 11 Aug 2020 17:46:11 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07133C06174A for ; Tue, 11 Aug 2020 14:46:10 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id t6so107408pjr.0 for ; Tue, 11 Aug 2020 14:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ekEmY1/ax+L0gbL+grpGSGz9Q9IPbEokzoRjtsOxC1U=; b=i5aLZDzI1JL4lb6HPqx8WlSa8C3dyiMON9IxEKkfdzKyX6Os6yQyAUR23IJqWf4Vdb 4IcWkrGq99RdvEDChPbSJk+gs09bd8XXuG37lllChucpF03voHQJZRWrbNL8IMQpZsr9 Z7rWA8UDIjlKl6dvW7XvCzj865A6Ut2BeBHJWdOMemcfprHDi2bhgW85TY9qeD54/+xh AG4WqTPxUzZAe1txrRklwcZAEng16ZCQZAtWy73VSaXLUsZxbt1qih1cUVjp+QzkYl8Y fNVP1i1vug7EGn5lg7HZ3HNZP4CiQ+tnHxYrRY2jawn8bdASYGbfy6rEmDqt0i10Xn/K W/9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ekEmY1/ax+L0gbL+grpGSGz9Q9IPbEokzoRjtsOxC1U=; b=NcSRZLzo9VPO/adxdgR1rL8ukd2fb0K7/aWETV7kY3JTug4WGZfphWMnZmwMiOXMd4 MtXAmzl7MGaIwVR+9p9sAV9yXucBMMImKrHcDSWqNtKOpxsLdEadgPs3rh8aSib9CGo2 AgjnXCQnHD3A/VssnWs20m+XuYItdbrG4fqENFfQnVJ7m2+rCt7JvNH9IAo7pepQnjrd 2MpD3m8AIm7/76JOzZ7ERJuRQbUYUlv+P6+4aPgrzoUa3s/ny6GsS0WcgYHoxsosaaLr Fip/JvW+ozFdJMNWED2zk81E+wkeboPerTFqhKGJiX3klFf+QjhJUGIX6C0GwBcK99vD /uPQ== X-Gm-Message-State: AOAM530RxTCNyUc5WfXHy1bg3W5e/4x6K1SQ6NPvHDHum4995CT/gOe+ WnlA/0rMjiNCTWbnmcKlpv2qxg== X-Received: by 2002:a17:902:c40f:: with SMTP id k15mr2700290plk.330.1597182370358; Tue, 11 Aug 2020 14:46:10 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id q83sm51671pfc.31.2020.08.11.14.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 14:46:09 -0700 (PDT) Date: Tue, 11 Aug 2020 14:46:09 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Baoquan He cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, sonnyrao@chromium.org, yuzhao@google.com Subject: Re: [PATCH] Revert "mm/vmstat.c: do not show lowmem reserve protection information of empty zone" In-Reply-To: <20200811075412.12872-1-bhe@redhat.com> Message-ID: References: <20200811075412.12872-1-bhe@redhat.com> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Aug 2020, Baoquan He wrote: > This reverts commit 26e7deadaae1755faf1f6d1a68988c4b8348df59. > > Sonny reported that one of their tests started failing on the latest > kernel on their Chrome OS platform. The root cause is that the above > commit removed the protection line of empty zone, while the parser used > in the test relies on the protection line to mark the end of each zone. > > Let's revert it to avoid breaking userspace testing or applications. > Acked-by: David Rientjes No objection since I noted userspace parsing as a potential risk in https://marc.info/?l=linux-mm&m=158507790824995 but I didn't catch this earlier patch which could have led to the same thing.