Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH drm/hisilicon v2 0/3] hibmc clean up and code refactoring
To:     Thomas Zimmermann <tzimmermann@suse.de>,
        Tian Tao <tiantao6@hisilicon.com>, <airlied@linux.ie>,
        <daniel@ffwll.ch>, <kraxel@redhat.com>,
        <alexander.deucher@amd.com>, <tglx@linutronix.de>,
        <dri-devel@lists.freedesktop.org>, <xinliang.liu@linaro.org>,
        <linux-kernel@vger.kernel.org>
CC:     <linuxarm@huawei.com>
References: <1596415114-21175-1-git-send-email-tiantao6@hisilicon.com>
 <312b8060-f015-35ba-f4f6-ad992aa09aa9@suse.de>
From:   "tiantao (H)" <tiantao6@huawei.com>
Message-ID: <8f558a5c-61b6-303a-0c2f-e0f63e9faa10@huawei.com>
Date:   Wed, 12 Aug 2020 15:12:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <312b8060-f015-35ba-f4f6-ad992aa09aa9@suse.de>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


在 2020/8/12 15:04, Thomas Zimmermann 写道:
> Hi
> 
> Am 03.08.20 um 02:38 schrieb Tian Tao:
>> patch #1 and #3 is clean up, patch #2 is for code refactoring
> 
> Sorry for all my reviews taking so long. Please merge patch #3 into
> patch #2 and then the series is
> 
thanks,I will send v3 to fix this.
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> 
> I noticed that hibmc use DRM_ERROR in several places. A good follow-up
> patchset would be the conversion to drm_info/drm_warn/drm_error/etc.
> 
I will send another patchset to fix this.
> Best regards
> Thomas
> 
>>
>> Changes since v1:
>> - Rewrite the commits messages and patch name in #1
>> - Rewrite the commits message in #2.
>> - Add the new patch #3
>>
>> Tian Tao (3):
>>    drm/hisilicon: Remove the unused include statements
>>    drm/hisilicon: Code refactoring for hibmc_drv_de
>>    drm/hisilicon: Rename variables to represent the correct meaning
>>
>>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c   | 58 ++++++------------------
>>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c  |  5 --
>>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h  |  2 +
>>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c |  2 -
>>   4 files changed, 15 insertions(+), 52 deletions(-)
>>
>