Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp384718pxa; Wed, 12 Aug 2020 04:47:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbEukrudDNIknMsplSr1dkWQTiHZ9jVIgjk1bZSuDmbVihNL/lHcSZtxho1ijFwO4fRb1N X-Received: by 2002:a17:907:7287:: with SMTP id dt7mr30022268ejc.224.1597232877208; Wed, 12 Aug 2020 04:47:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1597232877; cv=pass; d=google.com; s=arc-20160816; b=w4UAGJ4YreqtFEPQ3y8+xUgsG+IuL1rseBKxjmYAGQaF/lD/4HbaJ6M2zE0i03Jd7v g3LFA28IdSW3h9rZc3pbFMiQP1WMBckVj6vYGlWUtCvOMvOuCJurRGTEua2K4vxCuvTm zYuWchN48KhPwq+HPMqYvX4850kg1qi8+LdKszLVdn2izxJxZ3jCfRLyIAmhpIl/lnAz 6jHkYXWCEaPY3L0pBsQL8luaSVxCmJiQs1xyb8FfYh5inkwv/4Itxz7upQ8++T/LuCDj VPnjJv00vRqM58XBULSK6xK5eOoJDMic7b93Tnd8drDJj89wnvQyJFYxmByFT3cZ0w+Y 6jmg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:in-reply-to:user-agent:date:message-id:from :references:cc:to:subject:dkim-signature; bh=CYriiuePpzG5FClKRl/mweBYjO5CI8ailf/iWbNfzf0=; b=COCksX5ELHNPWBRSpO0dbH0mKoYCzHW3XK5ExV1o29S2QF7ESG2UekoZe4DtN4L2hX GPWl22grmwAPe+FhBjZabFFIf1gN4H85VEHEfP+/zcytQsEUZeZrjdz7yYezy8KN4NCE uO+Tjpnqg5+p2RW5hreiq6WYW1nwH1viS/P1gcdKtvG7d2zbGX28o1XN8vPinPx2tIcB Fr4V25+t3xWgdPjIqvS7FnV3D1VHjGhqITFttVLzYeLhS32LofJwekcSo8fc0Gv3oF4m ZxLV2rA7queEgfMfET0sv8TIbdT3w8FRJ7mLgSYxvn0GXAu3t1thZ26SrjOseXNFF+jU yaLg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@prevas.dk header.s=selector1 header.b=N4wFbFAi; arc=pass (i=1 spf=pass spfdomain=prevas.dk dkim=pass dkdomain=prevas.dk dmarc=pass fromdomain=prevas.dk); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p22si1112315eds.169.2020.08.12.04.47.34; Wed, 12 Aug 2020 04:47:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@prevas.dk header.s=selector1 header.b=N4wFbFAi; arc=pass (i=1 spf=pass spfdomain=prevas.dk dkim=pass dkdomain=prevas.dk dmarc=pass fromdomain=prevas.dk); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727808AbgHLLpK (ORCPT + 99 others); Wed, 12 Aug 2020 07:45:10 -0400 Received: from mail-eopbgr40136.outbound.protection.outlook.com ([40.107.4.136]:36310 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726404AbgHLLpI (ORCPT ); Wed, 12 Aug 2020 07:45:08 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AnAbf2btH/8q2j3KOYm7t6zdct0nGbOgTNR4Jbjjah3RAL0CyQwuh4TLyCMLrjeDTOTmnTYGGfzB7E05lUmG6ZdyEk798yPEty0Ly56/YxKxavuYvLR4Ygmwo9W22OLndbikz4pVSFY9RAb0q4Mdt4Et80oqTQ6cZlYQLu1ZOtgzKre74vBqS5jFOykXKqLtuCl784C/k1Zb2V/fG/zfwOzl1xNmT71k7hfTr6caAwvGcJx6J+dcQS7H4cj+YmfRMg9QDP6KMyenc6mtsdcVLtwsA0UFus2GV+XiCmXxcHlYvr7I9qeiijFt2AzDEe2iaVqx4YTZ2B30KuIa0h2O7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CYriiuePpzG5FClKRl/mweBYjO5CI8ailf/iWbNfzf0=; b=bvdWpRogUA09HTx99qYmMLlaaiHl+opz4sPg1qf8Kh7tOVx1rzEArE4ssgML2yZ8zRDou4Qu4Q/L5GB1m9dV8DDX0snGeMhZDBwbKydV1MGQp4Ubj4o8j0CpBIPd6vunLYGyxDwRW+zszoDUkf1bhIVI4qu/qeWEwdT/cTAuSl27s0QwX3W1h0tWNyWW0W4zU9319XUKSK7vSRpl13fbA1avLC786fU7FrgE9HcEKbbf3Wqq4bqU86t8WLCC4zc7V4z4F8kErCZFDTQORXTcTbLFTrjkJjA+Dm8aUUUCHPH35JMuWg/kg6xoonwzRpT6ce9HmJ445Y+4B/vsrmG+QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CYriiuePpzG5FClKRl/mweBYjO5CI8ailf/iWbNfzf0=; b=N4wFbFAi0daWoLXcOTb1mU2rTOJM+o/1tmkDy2B/WZWKQ2czLsXmKGjgo9Ihn8z2xzlMkvW4RJ9IxSbwXdM1m5aOByVPTLsANPLc1UXwslcnImL/4xYNc4l+E5lYt+9Xzt9see7wjg66PeTfMMaZrMidS8DKe5a17d8jyZiNgPA= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=prevas.dk; Received: from AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:3f::10) by AM0PR10MB1940.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:45::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16; Wed, 12 Aug 2020 11:45:05 +0000 Received: from AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM ([fe80::3cfb:a3e6:dfc0:37ec]) by AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM ([fe80::3cfb:a3e6:dfc0:37ec%3]) with mapi id 15.20.3261.025; Wed, 12 Aug 2020 11:45:05 +0000 Subject: Re: [PATCH linux-5.2.y-rt only] hrtimer: correct the logic for grab expiry lock To: zhantao.tang@windriver.com, linux-kernel@vger.kernel.org Cc: bigeasy@linutronix.de, tglx@linutronix.de, rostedt@goodmis.org, linux-rt-users@vger.kernel.org References: <20200812105053.602-1-zhantao.tang@windriver.com> From: Rasmus Villemoes Message-ID: <86790e56-9cec-5cea-8387-f7010b88708b@prevas.dk> Date: Wed, 12 Aug 2020 13:45:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20200812105053.602-1-zhantao.tang@windriver.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM4PR0501CA0061.eurprd05.prod.outlook.com (2603:10a6:200:68::29) To AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:3f::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [172.16.11.132] (81.216.59.226) by AM4PR0501CA0061.eurprd05.prod.outlook.com (2603:10a6:200:68::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15 via Frontend Transport; Wed, 12 Aug 2020 11:45:04 +0000 X-Originating-IP: [81.216.59.226] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6fbf2f82-3b67-4c32-5eaa-08d83eb527a2 X-MS-TrafficTypeDiagnostic: AM0PR10MB1940: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:635; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iSeGKw1f4V4tPRcabv8hdUWoikZhG/ZyOT63yYaNc5x/RoBU2O97yRiBTlbEFMA0QBr3lNPfVt/DtYdxXgRk1RyPWwMJd1V3pjka/zd2NYqaR8hAqPzGLzOXmwmgnW7r2Mi4a19o35sH+M7X0QZKdPTo/2ID9Me2aQ6FrpdwRcG7d3H5XJEddwXAqbcr0cTdZu6XGG1IWnSThddfuySlLieFZsHZmoG0VSjjrd75iaq/ZQ+KCWm2M05awRE4FN/0XNi7m5aHSpisEh5+lylwqgqQ/nDTsC0G413s9rMMmBx8Kq0afb0Jr1ZPsxX7Oy854rchDeKV40dNWHn629lTxtemOhfQgeoYb1TGWASm3JhHn9GoqLPDx1AICylmaUv7qmEP/KTmzk2gBiD01jDVFrfLgLrZlxbmzEoB+lHBPHFDC9sUZBmQdMIbMsn+weDGE+Oc2l6K8TbfiLHjWw3BqA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(346002)(396003)(376002)(39840400004)(136003)(366004)(6486002)(2616005)(44832011)(956004)(478600001)(31686004)(966005)(4326008)(16576012)(26005)(316002)(186003)(16526019)(8676002)(8936002)(8976002)(2906002)(52116002)(4744005)(31696002)(86362001)(36756003)(66476007)(5660300002)(83380400001)(66556008)(66946007)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: K1bgaPI5cVQ9PrfIrtGiA4gP9fMRQa+g/virk0EM8rlSRRozOeWzvBzg0zz6/W9mczoOCLbSbY8h2O31Hr0JaAkrw/tLtXvxkTrMXlAeEAdNMY0cxOctmMGunAsNO4A9SnOo10Fsn/dAXiiNa/wWKu07GXd/xN3JfOSec+ZcgFIKRYePvlCWiZFXLxKMBH9CeBqVSmx10f51Lbkh5I1yNbfP/zgGVnURYoTmAJX3Og8fFh39Pro1LM/ecReyB8nOvtPJ/XkKBqAf1SII2IDJpkO+/zQzMML5N864II+Lx0cSGKbhZpXA4V1G5YYaNahfK/diacttUJXM3zzCy0j6EnODKlTvil/PwGXjOpzplKLHCUHm3A8DXBfe0+yDQAqJ7pLfmtjEgcjEjwZW8YQH+o3dHi1PoyFL9N9TH8lgilBZ47SWyXz1bezQyXdJaj7luvDTnrX05P0856pgLjDRa974QZadSJh75XIwpUKDFucS4V9ddaAsdzdWFLTRlkksl4b9flGxnkSTfjC6t4L/YrWDq5BxP3OA2lInowOWAgTioS27BuEVBpnP1seMMq+fcDXIhq7t8B1cD0cFfc56CPvymmROVKrHmrbtfUeYC7pAKpq7raQ2W3c3P6FXxh0y8Zih7B/QM6DU0jRVmxw/aQ== X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: 6fbf2f82-3b67-4c32-5eaa-08d83eb527a2 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2020 11:45:04.9829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zih3rmY3ou6EFYwRSWjb6JlQQ2j/EnfBzRD7S1OLknvCV//7H0JfIFkVHbD1HiWOCQ/8j7EJhMfRCM2Ay8laRe9x6k7c6HvDayQMGJxqwtM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB1940 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08/2020 12.50, zhantao.tang@windriver.com wrote: > From: Zhantao Tang > > In commit: 47b6de0b7f22 ("hrtimer: Add a missing bracket and hide `migration_base' on !SMP") > a inline function is_migration_base() is introduced. But > the logic of the hrtimer_grab_expiry_lock was changed. > > This patch is to correct it. > Yup, same patch sent back in April, which also had a fixes tag for 5.2. https://lore.kernel.org/lkml/20200428144026.5882-1-rasmus.villemoes@prevas.dk/ It got picked up for 4.19-rt, dunno why it wasn't for 5.2-rt. Rasmus