Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp432072pxa; Wed, 12 Aug 2020 05:57:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMVN9V/pHKkHQAJis8kYBxO7feRgKNLXyPjti6gxU2Keqf47dTpe3w3Sj47WL9Yp8QDtG6 X-Received: by 2002:a17:906:817:: with SMTP id e23mr30759747ejd.203.1597237077813; Wed, 12 Aug 2020 05:57:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597237077; cv=none; d=google.com; s=arc-20160816; b=pmwt1qGFJBhixT+Ji+aJXVPtco57WFQLIcMnUWTMpDCnEe29qym7h4maB/1qQKHlGq DnesV3FcejKsR81WtrSIn+ow6mQIu4NGu8811AYk/QAYODWqsTH3lxW1AN9+PI/FaNT2 Y6ma+3Haw6lhsJ2Dijp6bBK4ovIYZ0Be8L7uu/lZwnpbQq0T+ChrzQ7wFyt1qTPYpkbx NveCK9Rn95aPCm8P9ip5m+j3XmNOHm4N9yOzVJOhNrB/VX+b93TaBpxVxUrsejtqNKet 1jXQjqX6MlqkBe0qvTmtdkj66F6Xf7IdPJab0j8aPRikekVNK6eBXiLoBPudmqCUPZWq tcZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=gvqwUcQIiJwnZ3uU6KLS3SUlputKYPIEH3TY3JnsWGI=; b=Z57o0o7dVVI6Y/beylgTImbVCrUakc5mnPGWpl2rrJitd7s/+QUv/XqVHC/lmTbUOk 5os7KvHNYtGiStdqsrylBIbEOccax7iQxffGNZlDiN7DGhDFgngM46NraG2QUgsftX65 +4KZuqj4I3kia26psVvdUA4jnqc4gBbeF92hQAFs3kQv/P24tzCiJIudsiB6L5GqBmCc 7tHiX2CBvPDkBKlIXtX96Fbjz+jAnMhnb0PKRK8FhaWRGVsEdE6SVwSI+5vyufi4vBzX MlYfAQ+pdzOaxc0VePGaLPVoPb4p88EzNlWSokh4ws8PncmP/8ofp+vov0KVhRoXBAyN bH8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b17si1064846ejd.636.2020.08.12.05.57.33; Wed, 12 Aug 2020 05:57:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728177AbgHLMyJ (ORCPT + 99 others); Wed, 12 Aug 2020 08:54:09 -0400 Received: from foss.arm.com ([217.140.110.172]:44684 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728082AbgHLMxc (ORCPT ); Wed, 12 Aug 2020 08:53:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BACA012FC; Wed, 12 Aug 2020 05:53:31 -0700 (PDT) Received: from e113632-lin.cambridge.arm.com (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8654E3F70D; Wed, 12 Aug 2020 05:53:30 -0700 (PDT) From: Valentin Schneider To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, morten.rasmussen@arm.com, Quentin Perret Subject: [PATCH v5 13/17] sched/topology: Mark SD_SERIALIZE as SDF_NEEDS_GROUPS Date: Wed, 12 Aug 2020 13:52:56 +0100 Message-Id: <20200812125300.11889-14-valentin.schneider@arm.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200812125300.11889-1-valentin.schneider@arm.com> References: <20200812125300.11889-1-valentin.schneider@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There would be no point in preserving a sched_domain with a single group just because it has this flag set. Add it to SD_DEGENERATE_GROUPS_MASK. Signed-off-by: Valentin Schneider --- include/linux/sched/sd_flags.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/linux/sched/sd_flags.h b/include/linux/sched/sd_flags.h index 9043d18ce418..6eb302528659 100644 --- a/include/linux/sched/sd_flags.h +++ b/include/linux/sched/sd_flags.h @@ -112,11 +112,12 @@ SD_FLAG(SD_SHARE_PKG_RESOURCES, SDF_SHARED_CHILD | SDF_NEEDS_GROUPS) * Only a single load balancing instance * * SHARED_PARENT: Set for all NUMA levels above NODE. Could be set from a - * different level upwards, but it doesn't change that if a domain has this flag - * set, then all of its parents need to have it too (otherwise the serialization - * doesn't make sense). + * different level upwards, but it doesn't change that if a + * domain has this flag set, then all of its parents need to have + * it too (otherwise the serialization doesn't make sense). + * NEEDS_GROUPS: No point in preserving domain if it has a single group. */ -SD_FLAG(SD_SERIALIZE, SDF_SHARED_PARENT) +SD_FLAG(SD_SERIALIZE, SDF_SHARED_PARENT | SDF_NEEDS_GROUPS) /* * Place busy tasks earlier in the domain -- 2.27.0