Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200810080625.1428045-1-elver@google.com>
In-Reply-To: <20200810080625.1428045-1-elver@google.com>
From:   Marco Elver <elver@google.com>
Date:   Wed, 12 Aug 2020 15:02:14 +0200
Message-ID: <CANpmjNP5WpDyfXDc=v6cerd5=GpKyCmBKAKH+6qLT6JrBGPqnw@mail.gmail.com>
Subject: Re: [PATCH] kcsan: Optimize debugfs stats counters
To:     "Paul E. McKenney" <paulmck@kernel.org>
Cc:     kasan-dev <kasan-dev@googlegroups.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 10 Aug 2020 at 10:06, Marco Elver <elver@google.com> wrote:
> Remove kcsan_counter_inc/dec() functions, as they perform no other
> logic, and are no longer needed.
>
> This avoids several calls in kcsan_setup_watchpoint() and
> kcsan_found_watchpoint(), as well as lets the compiler warn us about
> potential out-of-bounds accesses as the array's size is known at all
> usage sites at compile-time.
>
> Signed-off-by: Marco Elver <elver@google.com>
> ---
>  kernel/kcsan/core.c    | 22 +++++++++++-----------
>  kernel/kcsan/debugfs.c | 21 +++++----------------
>  kernel/kcsan/kcsan.h   | 12 ++++++------
>  kernel/kcsan/report.c  |  2 +-
>  4 files changed, 23 insertions(+), 34 deletions(-)

Hi Paul,

I think this one is good to apply. I do not expect conflicts with current -rcu.

Thanks,
-- Marco