Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200807133658.1866-1-christian.koenig@amd.com> <1975d7d1-8f94-5852-6ccc-19fde4d4a919@gmail.com>
In-Reply-To: <1975d7d1-8f94-5852-6ccc-19fde4d4a919@gmail.com>
From:   Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Wed, 12 Aug 2020 15:49:23 +0200
Message-ID: <CAKMK7uF7nTgJE38Krhnw9Ca4FtFpw4b=nFr8-tWqPxTkRrh=Pw@mail.gmail.com>
Subject: Re: RFC: How to adjust the trace pid?
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <ckoenig.leichtzumerken@gmail.com>
Cc:     amd-gfx list <amd-gfx@lists.freedesktop.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Dave Airlie <airlied@gmail.com>, Shashank.Sharma@amd.com,
        Alex Deucher <alexander.deucher@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 12, 2020 at 3:42 PM Christian K=C3=B6nig
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Ping? Daniel, Dave any opinion on this?

Type patch, cc: tracing people, see what they say? tbh I have no idea,
but they have been making unhappy noises about some of the tricks
we've played in the past in i915 tracepoints. So not everything is
cool in there.

Otherwise I guess just add another tracepoint parameter to dump the
correct userspace mm.

3rd option could be to dump the current mm (since I'm assuming those
threads do kthread_use/unuse_mm to impersonate the right userspace
process correctly) in the tracepoint infrastructure too?

Cheers, Daniel

> Christian.
>
> Am 07.08.20 um 15:36 schrieb Christian K=C3=B6nig:
> > Hi everybody,
> >
> > in amdgpu we got the following issue which I'm seeking advise how to cl=
eanly handle it.
> >
> > We have a bunch of trace points which are related to the VM subsystem a=
nd executed in either a work item, kthread or foreign process context.
> >
> > Now tracing the pid of the context which we are executing in is not rea=
lly that useful, so I'm wondering if we could just overwrite the pid record=
ed in the trace entry?
> >
> > The following patch does exactly that for the vm_grab_id() trace point,=
 but I'm not 100% sure if that is legal or not.
> >
> > Any ideas? Comments?
> >
> > Thanks,
> > Christian.
> >
> >
>


--=20
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch