Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <4da0c324952861608bca14df77720e805be881e5.camel@gmail.com>
Subject: Re: [PATCH v2 1/2] scsi: ufs: Cleanup completed request without
 interrupt notification
From:   Bean Huo <huobean@gmail.com>
To:     Stanley Chu <stanley.chu@mediatek.com>, avri.altman@wdc.com
Cc:     alim.akhtar@samsung.com, asutoshd@codeaurora.org,
        jejb@linux.ibm.com, martin.petersen@oracle.com, beanhuo@micron.com,
        bvanassche@acm.org, tomas.winkler@intel.com, cang@codeaurora.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Wed, 12 Aug 2020 16:42:39 +0200
In-Reply-To: <1597236472.26065.9.camel@mtkswgap22>
References: <20200811141859.27399-1-huobean@gmail.com>
         <20200811141859.27399-2-huobean@gmail.com>
         <1597236472.26065.9.camel@mtkswgap22>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-08-12 at 20:47 +0800, Stanley Chu wrote:
> Hi Avri, Bean,
> 
> On Tue, 2020-08-11 at 16:18 +0200, Bean Huo wrote:
> > From: Stanley Chu <stanley.chu@mediatek.com>
> > 
> > If somehow no interrupt notification is raised for a completed
> > request
> > and its doorbell bit is cleared by host, UFS driver needs to
> > cleanup
> > its outstanding bit in ufshcd_abort(). Otherwise, system may behave
> > abnormally by below flow:
> > 
> > After ufshcd_abort() returns, this request will be requeued by SCSI
> > layer with its outstanding bit set. Any future completed request
> > will trigger ufshcd_transfer_req_compl() to handle all "completed
> > outstanding bits". In this time, the "abnormal outstanding bit"
> > will be detected and the "requeued request" will be chosen to
> > execute
> > request post-processing flow. This is wrong because this request is
> > still "alive".
> > 
> > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> > Reviewed-by: Can Guo <cang@codeaurora.org>
> > Signed-off-by: Bean Huo <beanhuo@micron.com>
> 
> Thanks Bean's patch integration.
> 
> Like Avri's comment in https://patchwork.kernel.org/patch/11683381/
> I think you could add Acked-by tag from Avri.
> 

Hi Avri
do I need to re-send the patchset to add your Acked-by tag?
or you will sign your acked-by statement and append this patch?

Thanks,
Bean

> 
> 
> Hi Avri,
> 
> Please correct above description if required.
> Thanks for your review! : )
> 
> 
> Thanks,
> 
> Stanley Chu
>