Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   John Ogness <john.ogness@linutronix.de>
To:     Nick Desaulniers <ndesaulniers@google.com>
Cc:     gregkh@linuxfoundation.org, kexec@lists.infradead.org,
        linux-kernel@vger.kernel.org, parri.andrea@gmail.com,
        paulmck@kernel.org, peterz@infradead.org, pmladek@suse.com,
        rostedt@goodmis.org, sergey.senozhatsky.work@gmail.com,
        sergey.senozhatsky@gmail.com, tglx@linutronix.de,
        torvalds@linux-foundation.org, swboyd@chromium.org
Subject: Re: [PATCH v5 4/4] printk: use the lockless ringbuffer
In-Reply-To: <20200811204729.1116341-1-ndesaulniers@google.com>
References: <20200709132344.760-5-john.ogness@linutronix.de> <20200811204729.1116341-1-ndesaulniers@google.com>
Date:   Wed, 12 Aug 2020 18:46:22 +0206
Message-ID: <871rkb4y2x.fsf@jogness.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-08-11, Nick Desaulniers <ndesaulniers@google.com> wrote:
> From what I can tell, I think this patch ("printk: use the lockless
> ringbuffer") breaks lx-dmesg in CONFIG_GDB_SCRIPTS.
>
> (gdb) lx-dmesg
> Python Exception <class 'gdb.error'> No symbol "log_first_idx" in specified context.: 
> Error occurred in Python: No symbol "log_first_idx" in specified context.
>
> This command is used to dump the printk log buffer.
>
> It looks like the only places left in the kernel that reference are:
>
> - Documentation/admin-guide/kdump/gdbmacros.txt
> - Documentation/admin-guide/kdump/vmcoreinfo.rst
> - scripts/gdb/linux/dmesg.py
>
> I believe this commit removed log_first_idx, so all of the above
> probably need to be fixed up, too.

Thanks for pointing this out! I will get to work on a patch for this.

John Ogness