Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200809132529.264312-1-warthog618@gmail.com> <20200809132529.264312-3-warthog618@gmail.com>
 <CAMpxmJWe6Cjhwt3izuPLK-Xzvm=LqOy_nnZ7xg123+M_JgriLw@mail.gmail.com> <20200812015458.GA8760@sol>
In-Reply-To: <20200812015458.GA8760@sol>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Wed, 12 Aug 2020 19:48:53 +0200
Message-ID: <CAMpxmJVbVWKaY5QuUFn9XxhJQ2-YFRTowk13_Lnt9kyQT=+-WQ@mail.gmail.com>
Subject: Re: [PATCH v3 02/18] gpio: uapi: define uAPI v2
To:     Kent Gibson <warthog618@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 12, 2020 at 3:55 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> On Tue, Aug 11, 2020 at 09:11:41PM +0200, Bartosz Golaszewski wrote:
> > On Sun, Aug 9, 2020 at 3:26 PM Kent Gibson <warthog618@gmail.com> wrote:
> > >
> [snip]
> > >
> > > +/*
> > > + * Maximum number of requested lines.
> > > + *
> > > + * Must be no greater than 64 as bitmaps are limited to 64-bits, and a
> > > + * multiple of 2 to ensure 32/64-bit alignment of structs.
> > > + */
> > > +#define GPIO_V2_LINES_MAX 64
> > > +
> >
> > If we refer to bitmaps for which helpers are defined in
> > include/linux/bitmap.h then they're not limited to 64-bits. I'd just
> > say here that we want to fit into 64-bit integers for simplicity.
> >
>
> Strictly speaking, userspace doesn't know about include/linux/bitmap.h,
> but I'm happy to remove any ambiguity.
>
> Does this work for you?:
>
>  * Must be no greater than 64, as bitmaps are restricted here to 64-bits
>  * for simplicity, and a multiple of 2 to ensure 32/64-bit alignment of
>  * structs.
>
> Cheers,
> Kent.

Yes, perfect.

Bart