Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp726455pxa; Wed, 12 Aug 2020 11:54:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLAtFmB+/YZ5ytLtoxtUL4RlqVgqIkEXbBe/8IKPACQxo+mAOON2g5UchFbEjK5X23K3o7 X-Received: by 2002:aa7:cdc4:: with SMTP id h4mr1284335edw.252.1597258474587; Wed, 12 Aug 2020 11:54:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597258474; cv=none; d=google.com; s=arc-20160816; b=l9j1hme3KwlLMiSmwZJWi0jtODnMF7aPOvTOIKffrx6sHCH5ziQyihPYYBPw2DrPLg IqVlJNn8H/Nl14y3UUpoqDCADfqeH2puXKhlb6uLIyKbpJ1MWdWDXcFn35WeS7xepnsZ 7lW/zrwDYoQX6NDoxFA8dc7QA163XtHEah9LhbmBfzF0w3M+udF5eX4S3VBglFpRHsgh 24AZ848kKSqJnz5bW0N7SfvmqoKEdzICcsLnywGX+oxNaT+Wgo2F3tacVgwk7x9iIjZI ZWR2VN6YVUh7c7JLGZDHEZGWofiIj3Opn4vkNw6h1PFx11v4STZlS62PiIo18gfY7U3q mb5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=mvT9RAGgSpw435+n1f/WsXfGBWWLgcTYIOxF/LfVB2Y=; b=dwN1q99Ll4uV0E0cY68MNeoE8m5TjqeWyF9cT2mTA6xglIbsJ9500P1+bSolaKR0F+ Rwf19M0GcGoo412DvO4Q7RY2bWNso4VBCCU6Jej0lJYPGnDSbd34VzfZDW0vJc88zfXT koV710w2quR+sIITH33DFJMZdyMujHTWbSyDvLZ8or6mZw22sUfDt9runzYt1RDEMSDj Y1WpJ9cJhNbsuNq6MHjRmbYKSEn/F8gyH9TITpqNTfxe1YlIQowEe8xu7kjQqTMTAhGr eBsFscfrHt+7pSm4+8CzmR7qr4lRmrfp9+fWVGC+vK84/cK4XEvwMVpOXLJN5LtbXiUm KdwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=E5rFtQwa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id od24si1660956ejb.321.2020.08.12.11.54.11; Wed, 12 Aug 2020 11:54:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=E5rFtQwa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726600AbgHLSxI (ORCPT + 99 others); Wed, 12 Aug 2020 14:53:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726447AbgHLSxH (ORCPT ); Wed, 12 Aug 2020 14:53:07 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65255C061383 for ; Wed, 12 Aug 2020 11:53:07 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id t10so1504522plz.10 for ; Wed, 12 Aug 2020 11:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=mvT9RAGgSpw435+n1f/WsXfGBWWLgcTYIOxF/LfVB2Y=; b=E5rFtQwaqN5eeGvsDQ27/TvbwqKxFxXTL1048fKnJEqT4AxiG9QcsdUlPl+WFBow9B Zp8AQCh1S2z/fkjWfikMT4/jLfa0OUEq3xQk+4ECLtLCOYvlp0ITvbjS8FPRRHrWH1ps pFrlEWTi9HeETFb2vEaa7D+eZYX5zptymFIifZe9Abb54eraBfsJicthzuyAgpzRGBwo NuJ2C38C3XM3veHhiuSOxLDP8AIdywbiykEEqizIWs3mdPnJlRV2HMYZ+gX2yTa5CiUn xUkqLI7h0gk6K0d12a1zYjsFFaOtF7Ck/znPTgx+W57xAPBFKqhnWNvazvgXyxtC9jJ/ dKfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=mvT9RAGgSpw435+n1f/WsXfGBWWLgcTYIOxF/LfVB2Y=; b=TAbiPrCkSO4WqUj5LVwqBEswcfp8TRZWjxgLzcH9wjVMC4Mlxo3knfyhWXeNGCvu++ uIWy9IEEq64f+pg2xEPqqipEWxLoBDIb4kYGHiXpJviWZyFis51hnTbShIqAlfDhK9tF rLvKV/TrXQ8eJHsQNIw3bEX0n1zr4uXN8Buu5KFUF9rtaF41J+BuD/k7l/3UitxGv3jg /eXce+rMod7dRsEAuiFc/I35p+jeSUYo4dKqhRTar5vhh2bbfprU0LWhbJSC3Uhoso/t iHtCD2LY41PZRIIDYPyZXTAknv7Kq7mqZ7Lfv8HAORtrVZT3GY4CP5QW1ix+VS4VaEF8 EdGw== X-Gm-Message-State: AOAM533Vp1T/Cs5y6uV0MNekve6LXpIE5ALhbEIG49T9dbiL+8mqV+t9 YcUmqR9/tlsSxYfkth2dDL57vQ== X-Received: by 2002:a17:90b:808:: with SMTP id bk8mr1264847pjb.63.1597258386773; Wed, 12 Aug 2020 11:53:06 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id d127sm3120353pfc.175.2020.08.12.11.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 11:53:06 -0700 (PDT) Date: Wed, 12 Aug 2020 11:53:05 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Charan Teja Kalla cc: David Hildenbrand , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, vinmenon@codeaurora.org Subject: Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk() In-Reply-To: <848b7d60-2995-d9ae-0055-f3864dece11f@codeaurora.org> Message-ID: References: <1597150703-19003-1-git-send-email-charante@codeaurora.org> <848b7d60-2995-d9ae-0055-f3864dece11f@codeaurora.org> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Aug 2020, Charan Teja Kalla wrote: > >> Signed-off-by: Charan Teja Reddy > >> --- > >> > >> v1: https://patchwork.kernel.org/patch/11707637/ > >> > >> mm/page_alloc.c | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c > >> index e4896e6..839039f 100644 > >> --- a/mm/page_alloc.c > >> +++ b/mm/page_alloc.c > >> @@ -1304,6 +1304,11 @@ static void free_pcppages_bulk(struct zone *zone, int count, > >> struct page *page, *tmp; > >> LIST_HEAD(head); > >> > >> + /* > >> + * Ensure proper count is passed which otherwise would stuck in the > >> + * below while (list_empty(list)) loop. > >> + */ > >> + count = min(pcp->count, count); > >> while (count) { > >> struct list_head *list; > >> > >> > > > > Fixes: and Cc: stable... tags? > > Fixes: 5f8dcc21211a ("page-allocator: split per-cpu list into > one-list-per-migrate-type") > Cc: [2.6+] > Acked-by: David Rientjes