Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Alex Dewar <alex.dewar90@gmail.com>
Date:   Wed, 12 Aug 2020 20:02:53 +0100
To:     David Lechner <david@lechnology.com>
Cc:     Alex Dewar <alex.dewar90@gmail.com>,
        Sebastian Reichel <sre@kernel.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>,
        Bartosz Go??aszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH] power: supply: Add dependency to lego-ev3-battery
 Kconfig options
Message-ID: <20200812190253.zewvdfvyu6cnggcl@lenovo-laptop>
References: <20200809185444.54247-1-alex.dewar90@gmail.com>
 <d6c98ee6-f2f3-c55a-be16-3794ccf30a28@lechnology.com>
 <20200812133711.ddwhxypmvr27pxdu@lenovo-laptop>
 <ce0ae241-10e1-de5c-e694-2c00dc01a2c4@lechnology.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ce0ae241-10e1-de5c-e694-2c00dc01a2c4@lechnology.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 12, 2020 at 10:24:30AM -0500, David Lechner wrote:
> On 8/12/20 8:37 AM, Alex Dewar wrote:
> > On Tue, Aug 11, 2020 at 09:24:10AM -0500, David Lechner wrote:
> > > On 8/9/20 1:54 PM, Alex Dewar wrote:
> > > > This battery appears only to be used by a single board (DA850), so it
> > > > makes sense to add this to the Kconfig file so that users don't build
> > > > the module unnecessarily. It currently seems to be built for the x86
> > > > Arch Linux kernel where it's probably not doing much good.
> > > 
> > > It would probably also make sense to add "default n" since it only
> > > applies to one board in the entire arch.
> > 
> > Ah ok. That makes sense. Would you like me to send a follow-on patch for
> > this?
> 
> You can just send a v2 patch that includes the change below and the
> additional change.

I've just had a look at the documentation[1] and it seems that as there's
no "default y" there it'll default to n anyway. Have I got that right?

[1] https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html#menu-attributes

> 
> > 
> > Alex
> > 
> > > 
> > > BATTERY_LEGO_EV3 is already explicitly set to "m" in the appropriate
> > > defconfig file, so I don't think it would break anything.
> > > 
> > > > 
> > > > Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> > > > ---
> > > >    drivers/power/supply/Kconfig | 2 +-
> > > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> > > > index faf2830aa1527..9f76e2f47ac6d 100644
> > > > --- a/drivers/power/supply/Kconfig
> > > > +++ b/drivers/power/supply/Kconfig
> > > > @@ -164,7 +164,7 @@ config BATTERY_DS2782
> > > >    config BATTERY_LEGO_EV3
> > > >    	tristate "LEGO MINDSTORMS EV3 battery"
> > > > -	depends on OF && IIO && GPIOLIB
> > > > +	depends on OF && IIO && GPIOLIB && (ARCH_DAVINCI_DA850 || COMPILE_TEST)
> > > >    	help
> > > >    	  Say Y here to enable support for the LEGO MINDSTORMS EV3 battery.
> > > > 
> > > 
>