Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 12 Aug 2020 21:59:48 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <f65aeebb6c372a7138e496a30ce39f879d4e24ed.camel@pengutronix.de>
References: <20200812093726.10123-1-wenbin.mei@mediatek.com> <20200812093726.10123-4-wenbin.mei@mediatek.com> <f65aeebb6c372a7138e496a30ce39f879d4e24ed.camel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 3/3] mmc: mediatek: add optional module reset property
Reply-to: frank-w@public-files.de
To:     linux-mediatek@lists.infradead.org,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Wenbin Mei <wenbin.mei@mediatek.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
CC:     devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Chaotian Jing <chaotian.jing@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        linux-arm-kernel@lists.infradead.org
From:   Frank Wunderlich <frank-w@public-files.de>
Message-ID: <68A53B8B-6646-4A99-B1E3-FAC3D550D67E@public-files.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Tested with these 2 changes below too=2E

Am 12=2E August 2020 14:08:19 MESZ schrieb Philipp Zabel <p=2Ezabel@pengut=
ronix=2Ede>:

>> +	if (!IS_ERR(host->reset)) {
>> +		reset_control_assert(host->reset);
>> +		usleep_range(10, 50);
>> +		reset_control_deassert(host->reset);
>> +	}
>> +
>
>This should be:
>
>	if (host->reset) {
>		reset_control_assert(host->reset);
>		usleep_range(10, 50);
>		reset_control_deassert(host->reset);
>	}
>

>> +	host->reset =3D devm_reset_control_get_optional_exclusive(&pdev->dev,
>> +								"hrst");
>> +	if (PTR_ERR(host->reset) =3D=3D -EPROBE_DEFER)
>> +		return PTR_ERR(host->reset);
>> +
>
>This should be:
>
>	host->reset =3D devm_reset_control_get_optional_exclusive(&pdev->dev,
>								"hrst");
>	if (IS_ERR(host->reset))
>		return PTR_ERR(host->reset);
>

>With these two changes,
>
>Reviewed-by: Philipp Zabel <p=2Ezabel@pengutronix=2Ede>

regards Frank