Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200812192758.25587-1-sean.j.christopherson@intel.com>
In-Reply-To: <20200812192758.25587-1-sean.j.christopherson@intel.com>
From:   Ben Gardon <bgardon@google.com>
Date:   Wed, 12 Aug 2020 14:15:34 -0700
Message-ID: <CANgfPd8vsgdduEfWLaQSyJkAD1zMgDmGJM+wbCyAXM2zq=rtSg@mail.gmail.com>
Subject: Re: [PATCH v2 0/2] KVM: x86/mmu: Zap orphaned kids for nested TDP MMU
To:     Sean Christopherson <sean.j.christopherson@intel.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Peter Shier <pshier@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 12, 2020 at 12:28 PM Sean Christopherson
<sean.j.christopherson@intel.com> wrote:
>
> As promised, albeit a few days late.
>
> Ben, I kept your performance numbers even though it this version has
> non-trivial differences relative to what you tested.  I assume we'll need
> a v3 anyways if this doesn't provide the advertised performance benefits.
>
> Ben Gardon (1):
>   KVM: x86/MMU: Recursively zap nested TDP SPs when zapping last/only
>     parent
>
> Sean Christopherson (1):
>   KVM: x86/mmu: Move flush logic from mmu_page_zap_pte() to
>     FNAME(invlpg)
>
>  arch/x86/kvm/mmu/mmu.c         | 38 ++++++++++++++++++++++------------
>  arch/x86/kvm/mmu/paging_tmpl.h |  7 +++++--
>  2 files changed, 30 insertions(+), 15 deletions(-)
>

Thanks for sending this revised series Sean. This all looks good to me.
I think the main performance difference between this series and the
original patch I sent is only zapping nested TDP shadow pages, but I
expect it to behave more or less the same since the number of direct
TDP pages is pretty bounded.

>
> --
> 2.28.0
>