Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp930189pxa; Wed, 12 Aug 2020 17:34:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuPJDBl0dkSSXfv+GSO0uNCnbxZp8JIj9IySSYkjt+ZYj9P35WbgCz5h7NB59uVWjTJHxv X-Received: by 2002:a17:906:e10e:: with SMTP id gj14mr2510061ejb.218.1597278895131; Wed, 12 Aug 2020 17:34:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597278895; cv=none; d=google.com; s=arc-20160816; b=WIuKfJGbnoAGkFBHOMojhan2fkBSm6Lo0F4G6wGxHtDJyLS76LPO8Vu8R42HVCK7SX jegEq1TYDSdGb3hl3zAvIfE+TQOIbMVsIqn49jgiG1sCkkn6h8CfUpaYSojmTxCVcNyQ rmNW+3hFuwV01J5KRcPM9aBovSKxAdJ/EpVx5BYHAVOgINIY9Jrb4It/LL3CNhxXoyBY /TF6TzCV1FOR0rN32ERSlX3xcDNLkpEYHS1wgdQmcawyeX86CxUx9rgG0F7vTYTvy47h 43uNnHTsr4gQRNIpMqoQxCzX+/hEIzbRBz7YlCQcNXoswNWXxSnpRSeUtPjR69qyBcX/ fmJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=DK6cpoMIVfyVu3p4pB2161IxNHY/GDxfnQI+cNfyugo=; b=k2Hd/pCU/cOQxoWePwmKcuQOFOE2uLINH6ac8MkcjioYjpn3ZCQrnSnLUUF/6WfET8 p6JUsUpUfbR7cIlX/C0IrJcig6rS3mhkjyr8/uxyTwreqAqnxDYpkwLkxxyb0Gh6xtcv ityZXBBirdAba1v8+6LgQTwNexh1PiJtuZFz9XxPQPirijeUZVmiL6x1FDDC4ukRazgP C1WsTmwiy5egmvSP4T+Z0EipYnNnXqQMXxqn3b6jB4O3hmL5y/RrFK4VrH0f7+3Fjpgc uh/PffGqbOkr1gIMbrxGVVHR0iAt1rQuHwj+4ZfJReRloEcPZW8MUGvYLC2ZOJD4ypOE 7sQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZG+AL1r5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d23si2184360edp.84.2020.08.12.17.34.31; Wed, 12 Aug 2020 17:34:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZG+AL1r5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbgHMAcD (ORCPT + 99 others); Wed, 12 Aug 2020 20:32:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:56606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726523AbgHMAcD (ORCPT ); Wed, 12 Aug 2020 20:32:03 -0400 Received: from dhcp-10-100-145-180.wdl.wdc.com (unknown [199.255.45.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 421F620771; Thu, 13 Aug 2020 00:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597278722; bh=DK6cpoMIVfyVu3p4pB2161IxNHY/GDxfnQI+cNfyugo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZG+AL1r5NU/udFg4cl05Mi6MI9WssSOPQQ0fn9v5LXwYCDLVzjyTV+2PpGNeZiYkz IGl9HF7xLFWVDGJHZnyU7fcZb3yy2mfQFSXT2/2xG97PjnegHQcIuFKcO4vQ5lRz15 Cnb3E4XqVMCm2ldp9MAzByXqshGGdUznUybWP5+w= Date: Wed, 12 Aug 2020 17:32:00 -0700 From: Keith Busch To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Keith Busch , Jens Axboe Subject: Re: [PATCH v2] nvme: Use spin_lock_irq() when taking the ctrl->lock Message-ID: <20200813003200.GA1640756@dhcp-10-100-145-180.wdl.wdc.com> References: <20200812232444.18310-1-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200812232444.18310-1-logang@deltatee.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's an unrelated whitespace change in nvme_init_identify(). Otherwise, looks fine. Reviewed-by: Keith Busch