Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp957972pxa; Wed, 12 Aug 2020 18:29:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyasldEHuefjON06Kzq2wOhasOjVi969f/xS2UU0vAdTOZPxU95UvZob0QvyDdKyDTzx52i X-Received: by 2002:aa7:cc85:: with SMTP id p5mr2566162edt.369.1597282183512; Wed, 12 Aug 2020 18:29:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597282183; cv=none; d=google.com; s=arc-20160816; b=I2VxjZsr/bXPNV/AkdDM0V38Aq7L0QVbG9UsPghyJft9aqI5TETcPDOT5X/GUuTe36 IhyyRPqEAPcQNQPn1qxDixT3c6C7OGQ3tcoW9O+0mIlJEgIBr3nge1I5jprTGoDmHs4u xhbgVgijwKnG14pYShLa/FWP6v0NTo0iU20gCXN0kI+JXkgLOeL/yZrrIP4+7S3CAxQ8 F84FL6DbY22m5QLGvn+3NR/Gmm3Fp9R5XnBhVUMFca0+Ov3pXND5ymDzdnHNvQnmuZV7 xqQUFFWtAcwV7No3SaLeuezVlRjeD3SwrQ9jS0qVRaWMgzSS3YyUd5lUb32KElDsQ0eK Pp4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=34eflZdVGQ/NzNG47/bZTynvox1WRxIyejg4SQ2Q+a0=; b=wiOPxZQ4PLlX2ZH5rJuk5AjD4p4/E0J6fi3jm+886Ix1PDTuepgJ2UaZdN87HDhlXX epI50RMBgTn0Owweh99HLhgQlPThIeZLJ+RFpH9f0nFKTq8ZjWj/STURajKzT9PLbHnn v4aHj9DNaVmHiXLsoNaZEdfW719E2TnNpdsNjK6Y0kENrS9eHe0QGFV7RcCfw98xK9Dd YTq+Prvw03Lf7Owp/GuiCTuPzVNTcjIpeWJvNOIlaLQZiRjaImZQT19yo3ndl2qmn2So WGjSTh7rj89/FelZO0zYo0/eNpal5fs8PSB9FzkhbfP3efqktsf7LQFXGntSyywurRJ+ D5zQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s3si2290472edy.554.2020.08.12.18.29.20; Wed, 12 Aug 2020 18:29:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726603AbgHMB2o (ORCPT + 99 others); Wed, 12 Aug 2020 21:28:44 -0400 Received: from correo.us.es ([193.147.175.20]:57330 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbgHMB2n (ORCPT ); Wed, 12 Aug 2020 21:28:43 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 3619BDA79E for ; Thu, 13 Aug 2020 03:28:41 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 1862BDA73F for ; Thu, 13 Aug 2020 03:28:41 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 0D9D7DA72F; Thu, 13 Aug 2020 03:28:41 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,URIBL_BLOCKED,USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9C6DEDA704; Thu, 13 Aug 2020 03:28:38 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 13 Aug 2020 03:28:38 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (246.pool85-48-185.static.orange.es [85.48.185.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 111A542EE38E; Thu, 13 Aug 2020 03:28:37 +0200 (CEST) Date: Thu, 13 Aug 2020 03:28:35 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Simon Horman Cc: Julian Anastasov , Peilin Ye , Wensong Zhang , Cong Wang , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , Greg Kroah-Hartman , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel-mentees@lists.linuxfoundation.org, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH net-next v2] ipvs: Fix uninit-value in do_ip_vs_set_ctl() Message-ID: <20200813012835.GA1851@salvia> References: <20200810220703.796718-1-yepeilin.cs@gmail.com> <20200811074640.841693-1-yepeilin.cs@gmail.com> <20200811125956.GA31293@vergenet.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200811125956.GA31293@vergenet.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 11, 2020 at 02:59:59PM +0200, Simon Horman wrote: > On Tue, Aug 11, 2020 at 01:29:04PM +0300, Julian Anastasov wrote: > > > > Hello, > > > > On Tue, 11 Aug 2020, Peilin Ye wrote: > > > > > do_ip_vs_set_ctl() is referencing uninitialized stack value when `len` is > > > zero. Fix it. > > > > > > Reported-by: syzbot+23b5f9e7caf61d9a3898@syzkaller.appspotmail.com > > > Link: https://syzkaller.appspot.com/bug?id=46ebfb92a8a812621a001ef04d90dfa459520fe2 > > > Suggested-by: Julian Anastasov > > > Signed-off-by: Peilin Ye > > > > Looks good to me, thanks! > > > > Acked-by: Julian Anastasov > > Pablo, could you consider this for nf-next or should we repost when > net-next re-opens? No worries, it will sit in netfilter's patchwork until net-next reopens.