Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 13 Aug 2020 08:31:15 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Jacob Wen <jian.w.wen@oracle.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] block: insert a general SMP memory barrier before
 wake_up_bit()
Message-ID: <20200813073115.GA15436@infradead.org>
References: <20200813024438.13170-1-jian.w.wen@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200813024438.13170-1-jian.w.wen@oracle.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 13, 2020 at 10:44:38AM +0800, Jacob Wen wrote:
> wake_up_bit() uses waitqueue_active() that needs the explicit smp_mb().

Sounds like the barrier should go into wake_up_bit then..

> 
> Signed-off-by: Jacob Wen <jian.w.wen@oracle.com>
> ---
>  fs/block_dev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index 0ae656e022fd..e74980848a2a 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -1175,6 +1175,7 @@ static void bd_clear_claiming(struct block_device *whole, void *holder)
>  	/* tell others that we're done */
>  	BUG_ON(whole->bd_claiming != holder);
>  	whole->bd_claiming = NULL;
> +	smp_mb();
>  	wake_up_bit(&whole->bd_claiming, 0);
>  }
>  
> -- 
> 2.17.1
> 
---end quoted text---