Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Pawel Laszczak <pawell@cadence.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "weiyongjun1@huawei.com" <weiyongjun1@huawei.com>,
        "jpawar@cadence.com" <jpawar@cadence.com>,
        "kurahul@cadence.com" <kurahul@cadence.com>,
        "sparmar@cadence.com" <sparmar@cadence.com>
Subject: Re: [PATCH] usb: cdns3: Removes duplicated call to the
 cdns3_exit_roles function
Thread-Topic: [PATCH] usb: cdns3: Removes duplicated call to the
 cdns3_exit_roles function
Thread-Index: AQHWcUEJ2HYKtjM4M0WllTS952Uv86k1xJSA
Date:   Thu, 13 Aug 2020 09:25:20 +0000
Message-ID: <20200813092429.GA22195@b29397-desktop>
References: <20200813071054.25837-1-pawell@cadence.com>
In-Reply-To: <20200813071054.25837-1-pawell@cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <949C84F919CAF14486D9A3FA45AC3F01@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e0dc348-d883-4042-d89c-08d83f6acd02
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2020 09:25:20.9990
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ndbY2lE+kdWY/k+esyRkxarNwBkuMyi5Z4dbldMhd4hj166K58eDPP31Xr9WJnN1KtSsrPiguljE9uXGTs2hgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4166
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-08-13 09:10:54, Pawel Laszczak wrote:
> To avoid double calling of function cdns3_exit_roles when initialization
> failed
need ","

> patch removes invoking this function from cdns3_core_init_role.
> This function is invoked again from cdns3_probe when
> cdns3_core_init_role returns error code.

If you delete the cdns3_exit_roles here, where it will be called again?
I only see cdns3_exit_roles is called at .remove callback.

Peter
>=20
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
>  drivers/usb/cdns3/core.c | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)
>=20
> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> index 5c1586ec7824..c22c7224642a 100644
> --- a/drivers/usb/cdns3/core.c
> +++ b/drivers/usb/cdns3/core.c
> @@ -132,7 +132,7 @@ static int cdns3_core_init_role(struct cdns3 *cdns)
>  		if (ret) {
>  			dev_err(dev, "Host initialization failed with %d\n",
>  				ret);
> -			goto err;
> +			return ret;
>  		}
>  	}
> =20
> @@ -141,7 +141,7 @@ static int cdns3_core_init_role(struct cdns3 *cdns)
>  		if (ret) {
>  			dev_err(dev, "Device initialization failed with %d\n",
>  				ret);
> -			goto err;
> +			return ret;
>  		}
>  	}
> =20
> @@ -149,38 +149,34 @@ static int cdns3_core_init_role(struct cdns3 *cdns)
> =20
>  	ret =3D cdns3_drd_update_mode(cdns);
>  	if (ret)
> -		goto err;
> +		return ret;
> =20
>  	/* Initialize idle role to start with */
>  	ret =3D cdns3_role_start(cdns, USB_ROLE_NONE);
>  	if (ret)
> -		goto err;
> +		return ret;
> =20
>  	switch (cdns->dr_mode) {
>  	case USB_DR_MODE_OTG:
>  		ret =3D cdns3_hw_role_switch(cdns);
>  		if (ret)
> -			goto err;
> +			return ret;
>  		break;
>  	case USB_DR_MODE_PERIPHERAL:
>  		ret =3D cdns3_role_start(cdns, USB_ROLE_DEVICE);
>  		if (ret)
> -			goto err;
> +			return ret;
>  		break;
>  	case USB_DR_MODE_HOST:
>  		ret =3D cdns3_role_start(cdns, USB_ROLE_HOST);
>  		if (ret)
> -			goto err;
> +			return ret;
>  		break;
>  	default:
> -		ret =3D -EINVAL;
> -		goto err;
> +		return -EINVAL;
>  	}
> =20
>  	return 0;
> -err:
> -	cdns3_exit_roles(cdns);
> -	return ret;
>  }
> =20
>  /**
> --=20
> 2.17.1
>=20

--=20

Thanks,
Peter Chen=