Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 13 Aug 2020 11:51:06 +0200
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Thomas Zimmermann <tzimmermann@suse.de>
Cc:     Tian Tao <tiantao6@hisilicon.com>, airlied@linux.ie,
        daniel@ffwll.ch, kraxel@redhat.com, alexander.deucher@amd.com,
        tglx@linutronix.de, dri-devel@lists.freedesktop.org,
        xinliang.liu@linaro.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com
Subject: Re: [PATCH] drm/hisilicon: Fix build error of no type of module_init
Message-ID: <20200813095106.GK2352366@phenom.ffwll.local>
Mail-Followup-To: Thomas Zimmermann <tzimmermann@suse.de>,
        Tian Tao <tiantao6@hisilicon.com>, airlied@linux.ie,
        kraxel@redhat.com, alexander.deucher@amd.com, tglx@linutronix.de,
        dri-devel@lists.freedesktop.org, xinliang.liu@linaro.org,
        linux-kernel@vger.kernel.org, linuxarm@huawei.com
References: <1597289955-27381-1-git-send-email-tiantao6@hisilicon.com>
 <5e7ed4d6-8961-bdd0-6698-47571066357a@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5e7ed4d6-8961-bdd0-6698-47571066357a@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 13, 2020 at 10:03:18AM +0200, Thomas Zimmermann wrote:
> Hi
> 
> Am 13.08.20 um 05:39 schrieb Tian Tao:
> > Add missing include to fix build error:
> > hibmc_drm_drv.c:385:1: warning: data definition has no type or storage
> > class [enabled by default]
> > hibmc_drm_drv.c:385:1: error: type defaults to ‘int’ in declaration
> > of ‘module_init’ [-Werror=implicit-int]
> > hibmc_drm_drv.c:385:1: warning: parameter names (without types) in function
> > of ‘module_exit’ [-Werror=implicit-int]
> > hibmc_drm_drv.c:385:292:1: warning: parameter names (without types) in
> > function declaration [enabled by default]
> > 
> > Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> 
> I pushed the patch to drm-misc-next, but forgot to add my R-b tag. If
> anyone complains, it's my fault.

sob implies r-b generally, most maintainers do it like that and don't add
both their sob and r-b tag. That's also why dim doesn't enforce an r-b tag
in this case.
-Daniel
> 
> Best regards
> Thomas
> 
> > ---
> >  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> > index 1ae360d..2b4f821 100644
> > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> > @@ -11,6 +11,7 @@
> >   *	Jianhua Li <lijianhua@huawei.com>
> >   */
> >  
> > +#include <linux/module.h>
> >  #include <linux/pci.h>
> >  
> >  #include <drm/drm_atomic_helper.h>
> > 
> 
> -- 
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
> 


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch