Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1227763pxa; Thu, 13 Aug 2020 04:03:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycy8M3eau/nujyMIHzehgvg/6Db0qxs2Uq6nNv+wnuu8hDW21NojayBwJJmprwb+2Qmz5w X-Received: by 2002:a17:906:cc4a:: with SMTP id mm10mr4024127ejb.451.1597316601684; Thu, 13 Aug 2020 04:03:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597316601; cv=none; d=google.com; s=arc-20160816; b=CUIc0SqRpGJZ9/Vmbk/vIpF0/O2ykjFGKy14b9oHq47/3FsPViFgd20Y0oq/sIoW+0 wqeXAtE0dgajoILgXj7hIDmbiIyBzkOTWa+pqqQSnnP42wYg+CIXqV/5VVqkNm8XKP9/ mSqT1Xj9DGPcfWG9MJW4Q9vmyBbYFGpwL/mgDY9ynBbx98sSrfdXfG9qQR9JvkM9tVNZ t+ZLbw/+5nxY3uS6IW6/TXSgT1B+s4s3nnQoBnlxfqztEpMwPOXo8S1sRFRB0N0ZWTlY wDIlBp/fJbPfmRBvhEetxTC3k6UJ4zp0LSbJOBCmmS2BFqNQXlecir7CWm2fc5Kp4U4E mwfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=cqj1cyRcMo22JPCsUQj97oV6g8Vp6ijb+6eawSfLamM=; b=sneX6FZFgghKBUyvfxBcIAydtznnrA70HiLkz0Xmq6M/lFvFUCr854k+jcHj3W72hS UmW62XUUjntYJBoKqrg5asN6XUKHyqQ38RcsfBrBqGtdDfhyNvxPl0psvvGf4LFcXW2a Q2B2YbCtSypOLboZRQQGngTq+599f5Zz3m+KOf0pHbpga4PQuwJAmZgSjci/euupIkVU jI22FbdhxvlZBMc6PJ+V4gpJnFx+ya0tKm4roXFoH+s0pKsWeLogckTo7gu4l97FTeVn zlvEHT8Iy4Tssw6LQr1htnZoGe40S2aCDASjE7tHG7u5hAE6zrKhwXvK3/uQZ1UxQ6VL +xPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Rkx03hQ2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si2896129ejg.578.2020.08.13.04.02.58; Thu, 13 Aug 2020 04:03:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Rkx03hQ2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726673AbgHMLBc (ORCPT + 99 others); Thu, 13 Aug 2020 07:01:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbgHMLBa (ORCPT ); Thu, 13 Aug 2020 07:01:30 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A968C061757; Thu, 13 Aug 2020 04:01:25 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id bh1so2458666plb.12; Thu, 13 Aug 2020 04:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cqj1cyRcMo22JPCsUQj97oV6g8Vp6ijb+6eawSfLamM=; b=Rkx03hQ2ZuuoURjUOvIRaDuBT+77sPFb9qC91/eTlqfmIi0oDpxdD59Zcbwx4ysNwk SBfZqOCOd7w8ULkwbX7vn0XmmRd8RbXcYwodovSWjmBN7YdQWOBHvsIr6EPbQ/+mKrJW Yj/25zQtKRoB/2oZvy0Fnn5SAuEnssv2XwHpvl1vnE9mmsaTOzv9/K6D+6mRC5kDDD8r o7DJDmQgyHvbyEV/GnOnnE/F0b7rtKQCB8KubLjbu33fba+O6m+aoh7Cr+/k89JquCCt eb13QzlWUrGZS8owZzo0RtyiNO3y6IrQTeEvjSWiSdzBWKaxg9bPoo+Hol2iM26uWym/ mMuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cqj1cyRcMo22JPCsUQj97oV6g8Vp6ijb+6eawSfLamM=; b=RuDLWJB+yqQ6rgGbuQRRsmzlhg3aot3fojbbR1PGU/PRAXYhaaXgQBmhhN9oIgsvjF MHxDwG2vQ1rpMJRyEIXPOQ1TGgmiQF57eHOMbK+dGlGoN6Un7Q4flp4BZUhWG6THWsmj vrUOQL1VSRtPHSRB2+DJOPzoTtXcXyY0ScLXKCdLR7oEJ/TEh34nIQ1b2huE6mn22VoP dZqX1Oq6rtuhyavJnV6PgK7DIC92rlMG5z1iaRTVm4iwaPrfV+wEGS/GmTYsumnPCyV+ lIZ0CScVd5/cAdHmLL6/liGuag+OKvxrZ5i/FyKHGqHL4XwrVxroyIxCDtNXadGhHdA4 BOBw== X-Gm-Message-State: AOAM5313Dvhsq9CNmhRdREFUdU2t23mEnRLmeEVDZWUEOSOk6FA2phgW +nijGlf9JleI+zaiXlLclzsrnMUwh60yoBtJMqI= X-Received: by 2002:a17:902:4b:: with SMTP id 69mr3503017pla.18.1597316484554; Thu, 13 Aug 2020 04:01:24 -0700 (PDT) MIME-Version: 1.0 References: <20200813075125.4949-1-cmo@melexis.com> <20200813075125.4949-6-cmo@melexis.com> In-Reply-To: <20200813075125.4949-6-cmo@melexis.com> From: Andy Shevchenko Date: Thu, 13 Aug 2020 14:01:08 +0300 Message-ID: Subject: Re: [PATCH v5 5/5] iio:temperature:mlx90632: Some stylefixing leftovers To: Crt Mori Cc: Jonathan Cameron , linux-iio , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 13, 2020 at 10:53 AM Crt Mori wrote: > > There is some inconsistency and whitespace cleanup performed in this > patch. It was done on top of my other patches, but I can rebase to head > of the togreg branch if it would go in sooner. ... > -#define MLX90632_REF_12 12LL /**< ResCtrlRef value of Ch 1 or Ch 2 */ > -#define MLX90632_REF_3 12LL /**< ResCtrlRef value of Channel 3 */ > -#define MLX90632_MAX_MEAS_NUM 31 /**< Maximum measurements in list */ > -#define MLX90632_SLEEP_DELAY_MS 3000 /**< Autosleep delay */ > +#define MLX90632_REF_12 12LL /* ResCtrlRef value of Ch 1 or Ch 2 */ > +#define MLX90632_REF_3 12LL /* ResCtrlRef value of Channel 3 */ > +#define MLX90632_MAX_MEAS_NUM 31 /* Maximum measurements in list */ > +#define MLX90632_SLEEP_DELAY_MS 3000 /* Autosleep delay */ > #define MLX90632_EXTENDED_LIMIT 27000 /* Extended mode raw value limit */ This was actually in doxy (perhaps kernel doc also understands this) format of description. Can you double check that the kernel doc is okay / not okay with it? If it is okay, perhaps it's better to convert others to that format rather than dropping it. -- With Best Regards, Andy Shevchenko