Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1252943pxa; Thu, 13 Aug 2020 04:43:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/yCXloHoXo8wBITugxq1iiZp/rBYkv1GZmkGyLz4bJ+3Y19abKBf/rMP1pjc+3l4KNrcS X-Received: by 2002:a17:906:248f:: with SMTP id e15mr4105244ejb.296.1597318988446; Thu, 13 Aug 2020 04:43:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597318988; cv=none; d=google.com; s=arc-20160816; b=c4XNqy9KkCxatgEOOG667BVd1M6fDN9PRabvgOsPJkgVSOApxC4AkMDJUdTLKeZEqe icXqR/UIlj2tZAiEPS+ajSxrlo8u4ooWI64n5AhHPBb11XqSXTBJlzzA4yD9yaJ0tuz6 PAoxwM03sRM6wq7ED1bOBxOpca1bHRQu5wXa08geP/kXVKGeAdtg6kBBVys8g13lXQHP F6QHnsgIPyo2qD51zD7XM+ocuyE4hZ0pk9jcp9T4QpRBcX5yu1T1Cfu4bQbLcE8BYf8W /HY/Bz/pd9baGed/YjatKavOMQNxEzBBeD0QyXR2xlBWqfnbVNawTFT6LBzMNTHpgsL0 F4gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=2DtpeNiIF6S/B3g+Kt5wUDgMBKVuFkosm757FNhgE1A=; b=EQ/p7I+ovc9WGvwl7WckxzOOwtpxb8I6fwNd/aUM0fQI5DuYvnmZGbWx4TxcYpqNTA zAYm9tSzL5vF+b6yjoHtkUsDlAw9DKo4PtKL7HJ69xklVGwa4VkR2uxHTW8tBAHNeIws h/ANL4S7LoJFSzdS/b98BkHXBjWm0afJRwKT3xGH3xsV4XCBZByS0mxC6N6/QUIz7+qn VylL6mHvkhKAGuDKQviRtFkh0h+O61/nVTT3fC0mVQY2pPs7xTvM15Ue37HjqqiGWIpq 8cWKU2Yb+8R4zRH2H8cPwV5WrujoNXKht0N1KyYZdWc1tZLLla98jD6e7hV+H1zUVxyd z9IQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=M1f7WYXv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a8si3029239ejt.607.2020.08.13.04.42.45; Thu, 13 Aug 2020 04:43:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=M1f7WYXv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726131AbgHMLlu (ORCPT + 99 others); Thu, 13 Aug 2020 07:41:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbgHMLk6 (ORCPT ); Thu, 13 Aug 2020 07:40:58 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B250BC061757; Thu, 13 Aug 2020 04:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2DtpeNiIF6S/B3g+Kt5wUDgMBKVuFkosm757FNhgE1A=; b=M1f7WYXvppktqa9ZEJqZQXmJpI nWu1Csk9GhX1CtV5cvYEJLOo8ChGp77nDsOHCcJKT0Jh5QV34M25cdhhxaAKdnDr7mAr480EC43XI 9u+QgduTuSIMLKuOyYrOoCoVdhDH0KTAaHewOHXoutZ6kvy56QTN4C6jAOSOt2LTckyPQLq+CDnJY rrHz6/AKg7/tmBA9F/t1npfuFaFSPiMHfz4cJUo+mGvFvZ0SSw1A0cx2dmuCcPeXU45rdCpYnY4Qp 3jHOwqPVNaFlnM2/UWdAQa/Y6/SCW7lY7U4/WBfNG/HCNY6vrJ+jCgk85/e0Er05EkZWyuWVuFZCx Kn0V7eew==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6BbH-0002Qu-QI; Thu, 13 Aug 2020 11:40:52 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A20343003E5; Thu, 13 Aug 2020 13:40:50 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8E30F2C217FE7; Thu, 13 Aug 2020 13:40:50 +0200 (CEST) Date: Thu, 13 Aug 2020 13:40:50 +0200 From: peterz@infradead.org To: Christoph Hellwig Cc: Jacob Wen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: insert a general SMP memory barrier before wake_up_bit() Message-ID: <20200813114050.GW2674@hirez.programming.kicks-ass.net> References: <20200813024438.13170-1-jian.w.wen@oracle.com> <20200813073115.GA15436@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200813073115.GA15436@infradead.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 13, 2020 at 08:31:15AM +0100, Christoph Hellwig wrote: > On Thu, Aug 13, 2020 at 10:44:38AM +0800, Jacob Wen wrote: > > wake_up_bit() uses waitqueue_active() that needs the explicit smp_mb(). > > Sounds like the barrier should go into wake_up_bit then.. Oh, thanks for reminding me.. https://lkml.kernel.org/r/20190624165012.GH3436@hirez.programming.kicks-ass.net I'll try and get back to that.