Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 06/17] sched/debug: Output SD flag names rather than
 their values
To:     Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc:     kernel test robot <lkp@intel.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, kbuild-all@lists.01.org,
        mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org,
        dietmar.eggemann@arm.com, morten.rasmussen@arm.com,
        Quentin Perret <qperret@google.com>
References: <20200812125300.11889-7-valentin.schneider@arm.com>
 <202008130025.XjiXqp1O%lkp@intel.com> <jhjpn7v66lf.mognet@arm.com>
 <20200813120249.vdadn3nutkx3mq7y@ltop.local>
From:   Valentin Schneider <valentin.schneider@arm.com>
Message-ID: <2507c6d6-eb66-504e-aba6-1333ce064da8@arm.com>
Date:   Thu, 13 Aug 2020 14:13:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200813120249.vdadn3nutkx3mq7y@ltop.local>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 13/08/2020 13:02, Luc Van Oostenryck wrote:
> On Wed, Aug 12, 2020 at 07:51:08PM +0100, Valentin Schneider wrote:
>> On 12/08/20 17:35, kernel test robot wrote:
>>
>>> config: i386-randconfig-s001-20200811 (attached as .config)
>>> reproduce:
>>>         # sparse version: v0.6.2-168-g9554805c-dirty
>>>         make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
>>>
>>>>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving pointer to integer cast
>>>>> kernel/sched/debug.c:279:17: sparse: sparse: non size-preserving integer to pointer cast
>>>
>>>  > 279		tmp += *ppos;
>>
>> I pretty much copied kernel/sysctl.c::_proc_do_string() and I think that's
>> exactly the same types here: char* buffer incremented by loff_t offset. It
>> does look fine to me, but I can't really parse that warning.
> 
> The warnings mean that there is a cast from a pointer to an integer with
> a size other than the size of a pointer and the other way around.
> 
> I's indeed the case here, on i386, where pointers are 32-bit and loff_t
> is 64-bit. But yes, I agree:
> 1) these messages are far from clear
> 2) these casts are internal and are probably not appropriate here.
> 
> I'll look later what can be done at sparse level.
> 

Thanks!

> Regards,
> -- Luc
>